Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding "Pin" Button to ObjectPage Component #334

Closed
n-devlin opened this issue Feb 27, 2020 · 1 comment · Fixed by #354
Closed

Adding "Pin" Button to ObjectPage Component #334

n-devlin opened this issue Feb 27, 2020 · 1 comment · Fixed by #354
Assignees
@MarcusNotheis

Comments

@n-devlin
Copy link

Is your feature request related to a problem? Please describe.
In the Fiori 3.0 designs, the ObjectPage component includes a button alongside the expand/collapse header button to allow a user to "pin" the header in an expanded state. We would like to use this functionality to follow Fiori.

Describe the solution you'd like
The addition of a button (or ability to add a button ourselves) that allows a user to "pin" the header content of the ObjectPage component in an expanded state. This would allow a user to continue to scroll through content without pushing the header content into a collapsed state.

Additional context
Thank you!
@MarcusNotheis MarcusNotheis self-assigned this Feb 28, 2020
@MarcusNotheis MarcusNotheis mentioned this issue Mar 17, 2020
Merged
MarcusNotheis added a commit that referenced this issue Mar 19, 2020
@MarcusNotheis
feat(ObjectPage): Add 'Pin-Header' button (#354)
0e5e9b6 
This PR includes a full refactoring of the ObjectPage using native CSS capabilities instead of custom scroll handlers. This might lead to problems in IE11 and needs to be tested as well.

The Anchor Bar was replaced with the UI5 Web Component TabContainer in order to improve accessibility and RTL. --> #345

Closes #334
Closes #248
@MarcusNotheis
Copy link
Contributor

Release Candidate available: @ui5/webcomponents-react@0.8.7-rc.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarcusNotheis MarcusNotheis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ObjectPage): Add 'Pin-Header' button SAP/ui5-webcomponents-react
2 participants
@MarcusNotheis @n-devlin