feat(ObjectPage): Add 'Pin-Header' button #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icky-header-button
…icky-header-button
…icky-header-button
…icky-header-button
…icky-header-button
MarcusNotheis
requested review from
vbersch,
clemai and
Lukas742
and removed request for
vbersch
|
Minor bugs:
|
|
The mentioned bugs should be now fixed - ready for re-review. |
vbersch
requested changes
Mar 19, 2020
| @@ -17,6 +17,17 @@ export const Scroller = forwardRef((props: Props, ref: RefObject<IScroller>) => | |||
|
|
|||
| const elements = useRef([]); | |||
|
|
|||
| useEffect(() => { | |||
There was a problem hiding this comment.
The Scroller is basically deprecated. No need to introduce breaking changes here.
Lets add a deprecation notice to the Scroller.
| contentScrollContainer: { | ||
| position: 'relative' | ||
| '&::-webkit-scrollbar': { | ||
| backgroundColor: '#ffffff', |
There was a problem hiding this comment.
Theming Parameters? Pretty sure we didn´t have them in place before, but shouldn´t we actually?
|
|
||
| const anchorBarHeight = anchorBarRef.current?.offsetHeight ?? 33; | ||
|
|
||
| // const totalHeaderHeight = |
clemai
approved these changes
Mar 19, 2020
vbersch
approved these changes
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a full refactoring of the ObjectPage using native CSS capabilities instead of custom scroll handlers. This might lead to problems in IE11 and needs to be tested as well.
The Anchor Bar was replaced with the UI5 Web Component TabContainer in order to improve accessibility and RTL. --> #345
Closes #334
Closes #248