Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Notification): initial Implementation #171

Merged
merged 7 commits into from
Nov 7, 2019

Conversation

Lukas742
Copy link
Contributor

@Lukas742 Lukas742 commented Oct 7, 2019

Closes #159
Closes #160

@Lukas742 Lukas742 requested a review from MarcusNotheis October 7, 2019 11:55
@codecov-io
Copy link

codecov-io commented Oct 7, 2019

Codecov Report

Merging #171 into master will increase coverage by 0.21%.
The diff coverage is 81.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
+ Coverage   73.96%   74.17%   +0.21%     
==========================================
  Files         156      158       +2     
  Lines        3618     3721     +103     
  Branches      639      669      +30     
==========================================
+ Hits         2676     2760      +84     
- Misses        720      734      +14     
- Partials      222      227       +5
Impacted Files Coverage Δ
...es/main/src/components/NotificationGroup/index.tsx 100% <100%> (ø)
...ackages/main/src/components/Notification/index.tsx 80.8% <80.8%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc9bef3...f283f53. Read the comment docs.

@MarcusNotheis
Copy link
Contributor

I will leave this PR open for the moment, we want to make sure that all bugs are gone in v0.6.0 before we add new components.

packages/main/src/components/NotificationGroup/index.tsx Outdated Show resolved Hide resolved
packages/main/src/components/NotificationGroup/index.tsx Outdated Show resolved Hide resolved
packages/main/src/components/Notification/index.tsx Outdated Show resolved Hide resolved
packages/main/src/components/Notification/index.tsx Outdated Show resolved Hide resolved
packages/main/src/components/Notification/index.tsx Outdated Show resolved Hide resolved
packages/main/src/components/Notification/index.tsx Outdated Show resolved Hide resolved
packages/main/src/components/Notification/index.tsx Outdated Show resolved Hide resolved
@netlify
Copy link

netlify bot commented Oct 30, 2019

Deploy preview for ui5-webcomponents-react ready!

Built with commit f283f53

https://deploy-preview-171--ui5-webcomponents-react.netlify.com

packages/main/src/index.ts Outdated Show resolved Hide resolved
packages/main/src/index.ts Outdated Show resolved Hide resolved
@MarcusNotheis MarcusNotheis merged commit 78200e2 into master Nov 7, 2019
@MarcusNotheis MarcusNotheis deleted the feature/Notification branch November 7, 2019 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a Notification Group component Create a Notification component
3 participants