Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SideNavigation): Fix Rendering and Event Handling #189

Merged
merged 3 commits into from
Oct 18, 2019

Conversation

MarcusNotheis
Copy link
Contributor

Fixes #167
Fixes #161

@MarcusNotheis MarcusNotheis requested a review from vbersch October 17, 2019 18:19
@codecov-io
Copy link

codecov-io commented Oct 17, 2019

Codecov Report

Merging #189 into master will increase coverage by 0.09%.
The diff coverage is 92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
+ Coverage   73.67%   73.77%   +0.09%     
==========================================
  Files         150      150              
  Lines        3499     3500       +1     
  Branches      617      613       -4     
==========================================
+ Hits         2578     2582       +4     
+ Misses        708      705       -3     
  Partials      213      213
Impacted Files Coverage Δ
packages/main/src/webComponents/Popover/index.tsx 84.21% <100%> (-0.79%) ⬇️
...kages/main/src/components/SideNavigation/index.tsx 73.52% <50%> (+7.73%) ⬆️
...in/src/components/SideNavigationListItem/index.tsx 90.56% <95.23%> (-0.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24b27e5...e83453f. Read the comment docs.

@MarcusNotheis MarcusNotheis merged commit dc70d57 into master Oct 18, 2019
@MarcusNotheis MarcusNotheis deleted the fix/side-navigation-fixes branch October 18, 2019 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants