Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use onClick instead of onPress for button sample #192

Merged
merged 1 commit into from
Oct 18, 2019

Conversation

cgrail
Copy link
Member

@cgrail cgrail commented Oct 18, 2019

In the readme the sample code for the button doesn't work.

Changed in: #48

@CLAassistant
Copy link

CLAassistant commented Oct 18, 2019

CLA assistant check
All committers have signed the CLA.

@vbersch
Copy link
Contributor

vbersch commented Oct 18, 2019

Good find, thank you :)

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@a4bd68a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #192   +/-   ##
=========================================
  Coverage          ?   73.69%           
=========================================
  Files             ?      150           
  Lines             ?     3493           
  Branches          ?      616           
=========================================
  Hits              ?     2574           
  Misses            ?      706           
  Partials          ?      213

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4bd68a...19b80c9. Read the comment docs.

@MarcusNotheis MarcusNotheis merged commit 92c7ee8 into SAP:master Oct 18, 2019
@cgrail cgrail deleted the patch-1 branch October 18, 2019 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants