fix(ObjectPage): Prevent flickering and fix scroll to section #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemai
changed the title
- Ignore section header height when calculating dummy div height. - Prevent flickering of expanded/collapsed header. Fixes #25
|
Deploy preview for ui5-webcomponents-react ready! Built with commit 843ad17 https://deploy-preview-245--ui5-webcomponents-react.netlify.com |
Codecov Report
@@ Coverage Diff @@
## master #245 +/- ##
==========================================
- Coverage 72.57% 72.53% -0.05%
==========================================
Files 156 156
Lines 3464 3466 +2
Branches 603 605 +2
==========================================
Hits 2514 2514
- Misses 742 744 +2
Partials 208 208
Continue to review full report at Codecov.
|
|
Deploy preview for ui5-webcomponents-react ready! Built with commit 7d60d4e https://deploy-preview-245--ui5-webcomponents-react.netlify.com |
vbersch
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25