fix(withWebComponent): Add handler of events those are not specified in metadata of ui5-webcomponents #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Marcus Notheis <MarcusNotheis@users.noreply.github.com>
Co-Authored-By: Marcus Notheis <MarcusNotheis@users.noreply.github.com>
Co-Authored-By: Marcus Notheis <MarcusNotheis@users.noreply.github.com>
…in metadata of ui5-webcomponents
MarcusNotheis
approved these changes
Feb 12, 2020
Co-Authored-By: Marcus Notheis <MarcusNotheis@users.noreply.github.com>
fix(withWebComponent): The argument has default value, so the check logic of argument is no longer needed. Co-Authored-By: Marcus Notheis <MarcusNotheis@users.noreply.github.com>
|
Hi, @MarcusNotheis . I've forgot to use the default value of arguments. |
|
Hi @gnseo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, @MarcusNotheis .
For compatibility, I've updated withWebComponent to support events those are unsupported by ui5-webcomponents since onFocus event might be supported by ui5-webcomponents in sometime, if so, a runtime error would be occurred by the change.
Please check my code if it is acceptable.