Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AnalyticalCard): styling #360

Merged
merged 4 commits into from
Mar 18, 2020
Merged

fix(AnalyticalCard): styling #360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
50528bc
fix(AnalyticalCard): fix styling
Lukas742 Mar 18, 2020
3f80b02
Merge branch 'master' into fix/analytical-card-styling
Lukas742 Mar 18, 2020
2cc6659
fix(AnalyticalCard): change import
Lukas742 Mar 18, 2020
a085048
Update AnalyticalCardHeader.jss.ts
MarcusNotheis Mar 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/main/src/components/AnalyticalCard/AnalyticalCard.jss.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import * as spacing from '@ui5/webcomponents-react-base/lib/spacing';
const styles = {
card: {
backgroundColor: ThemingParameters.sapTile_Background,
border: `0.625rem solid ${ThemingParameters.sapTile_BorderColor}`,
border: `0.0625rem solid ${ThemingParameters.sapTile_BorderColor}`,
boxShadow: ThemingParameters.sapContent_Shadow0,
borderRadius: ThemingParameters.sapElement_BorderCornerRadius,
textAlign: 'start',
Expand Down
8 changes: 5 additions & 3 deletions packages/main/src/components/AnalyticalCardHeader/AnalyticalCardHeader.jss.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import * as spacing from '@ui5/webcomponents-react-base/lib/spacing';
import { ThemingParameters } from '@ui5/webcomponents-react-base/lib/ThemingParameters';

const styles = {
Expand All @@ -8,10 +9,11 @@ const styles = {
color: ThemingParameters.sapTextColor
},
cardHeader: {
paddingTop: '1rem',
paddingBottom: '1rem',
...spacing.sapUiContentPadding,
outlineOffset: '-0.125rem',
borderBottom: `0.0625rem solid ${ThemingParameters.sapTile_BorderColor}`,
boxShadow: ThemingParameters.sapContent_HeaderShadow,
//TODO use sapTile_SeparatorColor when available
borderBottom: `0.0625rem solid ${ThemingParameters.sapToolbar_SeparatorColor}`,
MarcusNotheis marked this conversation as resolved.
Show resolved Hide resolved
backgroundColor: ThemingParameters.sapTile_Background,
fontFamily: ThemingParameters.sapFontHeaderFamily,
'&:hover': {
Expand Down