charts/fix: fix(chartContainer): data handling #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new component for line chart based on the recharts library
- New Component: composed chart to display line and bar chart in one chart - Added Navigation bar for chart (composed chart and line chart) - New interfacesfor composed chart and composed line chart
Added clickhandler: datapoints and itemlegend in Linerechart Added clickhandler: itemlegend in ComposedCharts
Added config props to line chart - second y axis with color formatter and labels rework of click handler
reuse of chart container for composed charts
added bar chart component
Added clickHandler (data, legend) in BarRechart component
multiple fixes in the chart config object
- rework of composed chart (added clickhandler, defaultProps) - unit test of LineRechart created
- added pie / donut chart to recharts
- added custom hooks: formatter of data label and axis labels - replaced inline functions
- in beta.2, data labels don't work
- deleted inline functions in Pie- and Radar charts
- renaming of axis label hook - fix in pie chart
- charts weren't shown when dataset length = 0
MarcusNotheis
approved these changes
Mar 19, 2020
MarcusNotheis
approved these changes
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution! 👏
To get it merged faster, kindly review the checklist below:
Pull Request Checklist