Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(AnalyticalTable): Add Highlight Column #391

Merged
merged 3 commits into from
Mar 27, 2020
Merged

feat(AnalyticalTable): Add Highlight Column #391

merged 3 commits into from
Mar 27, 2020

Conversation

MarcusNotheis
Copy link
Contributor

Closes #312

@MarcusNotheis
Copy link
Contributor Author

I'm not 100% sure what is the best API for this feature.
Should we keep it as "classical" prop or should we put it somewhere in the table options?

@github-actions
Copy link

Coverage Status

Coverage increased (+0.2%) to 70.076% when pulling 9ec211d on feat/table-row-highlight into 32a647a on master.

@vbersch
Copy link
Contributor

vbersch commented Mar 27, 2020

I´m ok with the top level props approach. Do we even need the withRowHighlight prop? We could just infer highlighting rows as soon as hightlightField has been set.

@MarcusNotheis MarcusNotheis merged commit 69e648a into master Mar 27, 2020
@MarcusNotheis MarcusNotheis deleted the feat/table-row-highlight branch March 27, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukas742 Lukas742 Lukas742 approved these changes

@vbersch vbersch vbersch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Analytical Table: Highlight Items (rows)
3 participants
@MarcusNotheis @vbersch @Lukas742