feat(Framework): update to ui5-webcomponents-rc.6 #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Replace custom Avatar component with Web Component Avatar BREAKING CHANGE: Replace custom Carousel component with Web Component Carousel BREAKING CHANGE: Replace custom SegmentedButton component with Web Component SegmentedButton BREAKING CHANGE: Deleted SegmentedButtonItem, replaced by ToggleButton
BREAKING CHANGE: Remove AvatarSize `Custom` BREAKING CHANGE: Rename ButtonDesign `Accept` to `Positive` BREAKING CHANGE: Rename ButtonDesign `Reject` to `Negative` BREAKING CHANGE: Rename InputType `Url` to `URL`
vbersch
previously requested changes
Mar 30, 2020
There was a problem hiding this comment.
- BusyIndicator story: default value for active should be true
- Card story: Card looks different than in ui5-webcomponents demo
- list of BREAKING CHANGES is missing
- whats happening with the ComboBox story?
- Popover story: modal and noArrow should be false by default; same for ResponsivePopover
- Should we really keep two different toast components?
BREAKING CHANGE: Remove MessageToast Component, replaced by `Toast` UI5 Web Component BREAKING CHANGE: Remove prop `withToastContainer` from ThemeProvider
|
|
I was referring to the storybook shortcuts 't' and 's' that we talked about. Is there anything we can do about this at the moment? Thats a storybook bug, isn´t it? |
Lukas742
requested changes
Mar 30, 2020
packages/main/src/webComponents/MultiComboBox/MultiComboBox.stories.tsx
Outdated
Show resolved
Hide resolved
…ies.tsx Co-Authored-By: Lukas <lukas742@gmx.net>
Co-Authored-By: Lukas <lukas742@gmx.net>
Co-Authored-By: Lukas <lukas742@gmx.net>
…SAP/ui5-webcomponents-react into chore/update-webcomponents-rc-6
Lukas742
approved these changes
Mar 30, 2020
MarcusNotheis
changed the title
|
Deploy preview for ui5-webcomponents-react ready! Built with commit 64b9951 https://deploy-preview-392--ui5-webcomponents-react.netlify.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
Please look at the UI5 Web Components Changelog.
Breaking Changes
BREAKING CHANGE: Replace Avatar Component with
AvatarUI5 Web ComponentBREAKING CHANGE: Replace Carousel Component with
CarouselUI5 Web ComponentBREAKING CHANGE: Replace SegmentedButton Component with
SegmentedButtonUI5 Web ComponentBREAKING CHANGE: Deleted SegmentedButtonItem, replaced by ToggleButton
BREAKING CHANGE: Remove MessageToast Component, replaced by
ToastUI5 Web ComponentBREAKING CHANGE: ThemeProvider: Remove prop
withToastContainerBREAKING CHANGE: AvatarSize: Remove value
CustomBREAKING CHANGE: ButtonDesign: Rename
AccepttoPositiveBREAKING CHANGE: ButtonDesign: Rename
RejecttoNegativeBREAKING CHANGE: InputType: Rename
UrltoURLBREAKING CHANGE: CarouselArrowsPlacement: Rename
PageIndicatortoNavigationBREAKING CHANGE:BusyIndicator : change default size of busy dots to
MediumBREAKING CHANGE:Icon :
srcproperty is removed in favor ofnameBREAKING CHANGE:MessageStrip : replace icon property with icon slot to allow setting arbitrary content by the user
BREAKING CHANGE:MultiComboBox : Does not longer accept
StandardListItemas child, useMultiComboBoxIteminsteadBREAKING CHANGE:ShellBar : profile property is removed in favour of profile slot
BREAKING CHANGE:TabContainer :
onItemSelectevent is renamed toonTabSelectand the item event parameter is renamed to tab.BREAKING CHANGE:Card : the property
subtitlehas been renamed tosubheadingBREAKING CHANGE:TextArea : the property
maxLengthhas been renamed tomaxlengthBREAKING CHANGE:ThemeProvider : new prop
themeis required for correct theming in addition to importingimport '@ui5/webcomponents-react/lib/ThemingSupport'BREAKING CHANGE: configuring of compact size is removed, use the
ui5-content-density-compactCSS class to apply compact size.Closes #349