Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AnalyticalTable): remove padding and scrollbar from select-all header cell #536

Merged
merged 2 commits into from
May 22, 2020
Merged

fix(AnalyticalTable): remove padding and scrollbar from select-all header cell #536

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fec4a44
fix(AnalyticalTable): remove padding and scrollbar from select-all he…
Lukas742 May 22, 2020
8ba4dce
push fix down to css classes
MarcusNotheis May 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/main/src/components/AnalyticalTable/ColumnHeader/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,10 @@ export const ColumnHeader: FC<ColumnHeaderProps> = (props: ColumnHeaderProps) =>
const modifiedStyles: CSSProperties = {
cursor: hasPopover ? 'pointer' : 'auto'
};
if (column.id === '__ui5wcr__internal_selection_column') {
modifiedStyles.padding = 0;
modifiedStyles.overflowY = 'hidden';
}
if (dragOver) {
modifiedStyles.borderLeft = `3px solid ${ThemingParameters.sapSelectedColor}`;
}
Expand Down
4 changes: 2 additions & 2 deletions packages/main/src/components/AnalyticalTable/__snapshots__/AnalyticalTable.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1547,7 +1547,7 @@ exports[`AnalyticalTable Tree Table 1`] = `
>
<div
class="TableColumnHeader-header-0"
style="cursor: auto;"
style="cursor: auto; padding: 0px; overflow-y: hidden;"
>
<span
class="Text-text-0 Text-noWrap-0 TableColumnHeader-text-0"
Expand Down Expand Up @@ -5028,7 +5028,7 @@ exports[`AnalyticalTable with highlight row 1`] = `
>
<div
class="TableColumnHeader-header-0"
style="cursor: auto;"
style="cursor: auto; padding: 0px; overflow-y: hidden;"
>
<span
class="Text-text-0 Text-noWrap-0 TableColumnHeader-text-0"
Expand Down
2 changes: 1 addition & 1 deletion packages/main/src/components/AnalyticalTable/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,7 @@ const AnalyticalTable: FC<TableProps> = forwardRef((props: TableProps, ref: Ref<
return (
// eslint-disable-next-line react/jsx-key
<header {...headerProps} role="rowgroup">
{headerGroup.headers.map((column, index) => (
{headerGroup.headers.map((column) => (
// eslint-disable-next-line react/jsx-key
<ColumnHeader
{...column.getHeaderProps()}
Expand Down