Skip to content

Commit

Permalink
fix(ui5-li-notification-group): visual fixes for right-to-left mode (#…
Browse files Browse the repository at this point in the history
…4354)

- "collapse" arrow is now pointing down in RTL
- buttons and status icons are correctly aligned in RTL
- background is not switching to blue when user taps (on touch device)

Fixes #4255
Fixes #4256
Fixes #4257
  • Loading branch information
LidiyaGeorgieva authored Nov 25, 2021
1 parent f80a683 commit 13b7d68
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 0 deletions.
14 changes: 14 additions & 0 deletions packages/fiori/src/themes/NotificationListGroupItem.css
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@
transform: rotate(90deg);
}

:host(:not([collapsed])) [dir="rtl"] .ui5-nli-group-toggle-btn {
transform: rotate(270deg);
}

:host([collapsed]) .ui5-nli-group-items {
display: none;
}
Expand All @@ -35,6 +39,10 @@
cursor: default;
}

[dir="rtl"] .ui5-nli-group-header {
padding: 0.75rem 0.75rem 0.25rem 0.5rem;
}

.ui5-nli-group-toggle-btn {
margin-right: 0.75rem;
cursor: pointer;
Expand Down Expand Up @@ -64,9 +72,15 @@

[dir="rtl"] .ui5-nli-group-toggle-btn {
margin-left: 1rem;
margin-right: 0;
}

[dir="rtl"] .ui5-nli-group-counter {
margin-right: 0.25rem;
margin-left: 1rem;
}

/* fix for blue background color on tap (touchscreen devices) */
:host([ui5-li-notification-group]) {
-webkit-tap-highlight-color: transparent;
}
4 changes: 4 additions & 0 deletions packages/fiori/src/themes/NotificationListItem.css
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,10 @@
cursor: pointer;
}

[dir="rtl"].ui5-nli-root {
padding: 1rem 1rem 1rem 0.5rem;
}

.ui5-nli-content {
display: flex;
flex-direction: column;
Expand Down

0 comments on commit 13b7d68

Please sign in to comment.