Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arrow direction of ui5-notification-list-group-item: issue found from mobile exploratory testing on Android #4255

Closed
1 of 4 tasks
dimovpetar opened this issue Nov 3, 2021 · 0 comments · Fixed by #4354
Closed
1 of 4 tasks

Arrow direction of ui5-notification-list-group-item: issue found from mobile exploratory testing on Android #4255

dimovpetar opened this issue Nov 3, 2021 · 0 comments · Fixed by #4354
Assignees
@LidiyaGeorgieva
Labels
1.0 Release Testing bug This issue is a bug in the code Low Prio TOPIC RD

Comments

@dimovpetar
Copy link
Contributor

Bug Description

The direction of the arrow is wrong in RTL mode. It points up.

Steps to Reproduce

  1. Open https://sap.github.io/ui5-webcomponents/playground/components/NotificationListGroupItem/?sap-ui-theme=sap_fiori_3&isrtl=true
  2. Go to the sample NotificationListGroupItem In ShellBar
  3. Open the notifications

Context

  • UI5 Web Components version: master
  • OS/Platform: Android
  • Browser: Chrome
  • Affected component: ui5-notification-list-group-item

Log Output / Stack Trace / Screenshots

image

Priority

  • Low
  • Medium
  • High
  • Very High
@dimovpetar dimovpetar added 1.0 Release Testing bug This issue is a bug in the code labels Nov 8, 2021
@LidiyaGeorgieva LidiyaGeorgieva self-assigned this Nov 17, 2021
LidiyaGeorgieva added a commit that referenced this issue Nov 17, 2021
@LidiyaGeorgieva
fix(ui5-li-notification-group): visual fixes for right-to-left mode
89628ad 
- "collapse" arrow is now pointing down in RTL
- buttons and status icons are correctly aligned in RTL
- background is not switching to blue when user taps (on touch device)

Fixes #4255
Fixes #4256
Fixes #4257
@LidiyaGeorgieva LidiyaGeorgieva mentioned this issue Nov 17, 2021
Merged
2 tasks
ilhan007 pushed a commit that referenced this issue Nov 25, 2021
@LidiyaGeorgieva
fix(ui5-li-notification-group): visual fixes for right-to-left mode (#…
13b7d68 
…4354)

- "collapse" arrow is now pointing down in RTL
- buttons and status icons are correctly aligned in RTL
- background is not switching to blue when user taps (on touch device)

Fixes #4255
Fixes #4256
Fixes #4257
ndeshev pushed a commit to ndeshev/ui5-webcomponents that referenced this issue Dec 13, 2021
@LidiyaGeorgieva @ndeshev
fix(ui5-li-notification-group): visual fixes for right-to-left mode (S…
4ab16c6 
…AP#4354)

- "collapse" arrow is now pointing down in RTL
- buttons and status icons are correctly aligned in RTL
- background is not switching to blue when user taps (on touch device)

Fixes SAP#4255
Fixes SAP#4256
Fixes SAP#4257
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LidiyaGeorgieva LidiyaGeorgieva

Labels
1.0 Release Testing bug This issue is a bug in the code Low Prio TOPIC RD
Projects
Maintenance - Topic RD
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-li-notification-group): visual fixes for right-to-left mode SAP/ui5-webcomponents
2 participants
@LidiyaGeorgieva @dimovpetar