Skip to content

Commit

Permalink
refactor(ui5-combobox): extract listItem inline (#7194)
Browse files Browse the repository at this point in the history
  • Loading branch information
vladitasev authored and Nayden Naydenov committed Jun 15, 2023
1 parent 0a6f7a3 commit 3c06b86
Showing 1 changed file with 16 additions and 12 deletions.
28 changes: 16 additions & 12 deletions packages/main/src/ComboBoxPopover.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -76,17 +76,7 @@
{{#if isGroupItem}}
<ui5-li-groupheader ?focused={{this.focused}}>{{ this.text }}</ui5-li-groupheader>
{{else}}
<ui5-li
type="Active"
additional-text={{this.additionalText}}
group-name={{this.groupName}}
._tabIndex={{itemTabIndex}}
.mappedItem={{this}}
?selected={{this.selected}}
?focused={{this.focused}}
>
{{this.text}}
</ui5-li>
{{> listItem}}
{{/if}}

{{/each}}
Expand Down Expand Up @@ -127,4 +117,18 @@
{{this}}
{{/each}}
{{/if}}
{{/inline}}
{{/inline}}

{{#*inline "listItem"}}
<ui5-li
type="Active"
additional-text={{this.additionalText}}
group-name={{this.groupName}}
._tabIndex={{itemTabIndex}}
.mappedItem={{this}}
?selected={{this.selected}}
?focused={{this.focused}}
>
{{this.text}}
</ui5-li>
{{/inline}}

0 comments on commit 3c06b86

Please sign in to comment.