fix(ui5-view-settings-dialog): adjust reset button announcement (#10320)

Related to: #10191
SAP · Jan 15, 2025 · 42b29f3 · 42b29f3
1 parent 5493f68
commit 42b29f3
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 0 deletions.
diff --git a/packages/fiori/src/ViewSettingsDialog.ts b/packages/fiori/src/ViewSettingsDialog.ts
@@ -11,6 +11,8 @@ import type { ChangeInfo } from "@ui5/webcomponents-base/dist/UI5Element.js";
 import type Dialog from "@ui5/webcomponents/dist/Dialog.js";
 import type List from "@ui5/webcomponents/dist/List.js";
 import type { ListItemClickEventDetail } from "@ui5/webcomponents/dist/List.js";
+import announce from "@ui5/webcomponents-base/dist/util/InvisibleMessage.js";
+import InvisibleMessageMode from "@ui5/webcomponents-base/dist/types/InvisibleMessageMode.js";
 
 import ViewSettingsDialogMode from "./types/ViewSettingsDialogMode.js";
 import "@ui5/webcomponents-icons/dist/sort.js";
@@ -29,6 +31,9 @@ import {
 	VSD_ORDER_ASCENDING,
 	VSD_ORDER_DESCENDING,
 	VSD_FILTER_BY,
+	VSD_SORT_TOOLTIP,
+	VSD_FILTER_TOOLTIP,
+	VSD_RESET_BUTTON_ACTION,
 } from "./generated/i18n/i18n-defaults.js";
 
 // Template
@@ -340,6 +345,18 @@ class ViewSettingsDialog extends UI5Element {
 		return ViewSettingsDialog.i18nBundle.getText(VSD_SORT_BY);
 	}
 
+	get _sortButtonTooltip() {
+		return ViewSettingsDialog.i18nBundle.getText(VSD_SORT_TOOLTIP);
+	}
+
+	get _filterButtonTooltip() {
+		return ViewSettingsDialog.i18nBundle.getText(VSD_FILTER_TOOLTIP);
+	}
+
+	get _resetButtonAction() {
+		return ViewSettingsDialog.i18nBundle.getText(VSD_RESET_BUTTON_ACTION);
+	}
+
 	get _isPhone() {
 		return isPhone();
 	}
@@ -636,6 +653,7 @@ class ViewSettingsDialog extends UI5Element {
 		this._restoreSettings(this._initialSettings);
 		this._recentlyFocused = this._sortOrder!;
 		this._focusRecentlyUsedControl();
+		announce(this._resetButtonAction, InvisibleMessageMode.Polite);
 	}
 
 	/**

diff --git a/packages/fiori/src/ViewSettingsDialogTemplate.tsx b/packages/fiori/src/ViewSettingsDialogTemplate.tsx
@@ -50,11 +50,13 @@ function ViewSettingsDialogTemplateHeader(this: ViewSettingsDialog) {
 								selected={this.isModeSort}
 								icon={sortIcon}
 								data-mode="Sort"
+								tooltip={this._sortButtonTooltip}
 							/>
 							<SegmentedButtonItem
 								selected={this.isModeFilter}
 								icon={filterIcon}
 								data-mode="Filter"
+								tooltip={this._filterButtonTooltip}
 							/>
 						</SegmentedButton>
 					</div>

diff --git a/packages/fiori/src/i18n/messagebundle.properties b/packages/fiori/src/i18n/messagebundle.properties
@@ -206,6 +206,15 @@ VSD_CANCEL_BUTTON=Cancel
 #XFLD: View Settings Dialog Reset button text
 VSD_RESET_BUTTON=Reset
 
+#XMSG: View Settings Dialog Reset button invisible message text
+VSD_RESET_BUTTON_ACTION=Reset has reverted all settings to initial state
+
+#XTOL View Settings Dialog Sort button tooltop text
+VSD_SORT_TOOLTIP=Sort
+
+#XTOL View Settings Dialog Filter button tooltop text
+VSD_FILTER_TOOLTIP=Filter
+
 #XBLI: View Settings Dialog Sort Order group header text
 VSD_SORT_ORDER=Sort Order