fix(ui5-dynamic-page): move subheading slot outside the title wrapper (…

…#10163) fix(ui5-dynamic-page): move subheading slot outside title wrapper for layout consistency
SAP · Nov 13, 2024 · 6466b8a · 6466b8a
1 parent 614fc77
commit 6466b8a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/packages/fiori/src/DynamicPageTitle.hbs b/packages/fiori/src/DynamicPageTitle.hbs
@@ -28,7 +28,6 @@
       @ui5-_min-content-width-change={{onMinContentWidthChange}}>
       <div id="{{_id}}-heading" class="ui5-dynamic-page-title--heading">
         <slot name="{{headingSlotName}}"></slot>
-        <slot name="{{subheadingSlotName}}"></slot>
       </div>
 
       {{#if hasContent}}
@@ -49,7 +48,7 @@
         {{/unless}}
       </div>
     </div>
-
+    <slot name="{{subheadingSlotName}}"></slot>
   {{/if}}
 
   <span id="{{_id}}-toggle-description" class="ui5-hidden-text">{{_ariaDescribedbyText}}</span>

diff --git a/packages/fiori/test/pages/styles/DynamicPage.css b/packages/fiori/test/pages/styles/DynamicPage.css
@@ -63,6 +63,7 @@ html, body {
 }
 .snapped-title-heading [ui5-avatar] {
     position: absolute;
+    top: 0;
 }
 .snapped-title-heading [ui5-title] {
     font-family: var(--sapObjectHeader_Title_FontFamily);

diff --git a/packages/website/docs/_samples/fiori/DynamicPage/Basic/main.css b/packages/website/docs/_samples/fiori/DynamicPage/Basic/main.css
@@ -61,6 +61,7 @@
 }
 .snapped-title-heading [ui5-avatar] {
     position: absolute;
+    top: 0;
 }
 .snapped-title-heading [ui5-title] {
     font-family: var(--sapObjectHeader_Title_FontFamily);