Skip to content

Commit

Permalink
fix(ui5-popover): Calculate max content height (#3386)
Browse files Browse the repository at this point in the history
Resolves #3131

This fix steps on the following commit: e35cc1a
It enhances it in a way that Popover.MIN_OFFSET is taken into account into Popover's
maxContentHeight.
Popover.MIN_OFFSET is used when calculating the offset of the Popover from the top, but has never been extracted from the content's height.
  • Loading branch information
d3xter666 authored Jun 4, 2021
1 parent 0ecb3c8 commit 8cba688
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/main/src/Popover.js
Original file line number Diff line number Diff line change
Expand Up @@ -562,7 +562,7 @@ class Popover extends Popup {
}
}

this._maxContentHeight = maxContentHeight;
this._maxContentHeight = maxContentHeight - Popover.MIN_OFFSET;

const arrowPos = this.getArrowPosition(targetRect, popoverSize, left, top, isVertical);

Expand Down

0 comments on commit 8cba688

Please sign in to comment.