Skip to content

Commit

Permalink
fix(ui5-shellbar): correct accessibility DOM (#5395)
Browse files Browse the repository at this point in the history
  • Loading branch information
nnaydenow authored Jun 27, 2022
1 parent a359ebf commit aba5fb5
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 3 deletions.
12 changes: 9 additions & 3 deletions packages/fiori/src/ShellBar.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,12 @@
</span>
{{/unless}}

{{#if showTitleInMenuButton}}
<h1 class="ui5-hidden-text">
{{primaryTitle}}
</h1>
{{/if}}

{{#if showMenuButton}}
<button class="{{classes.button}}"
@click="{{_header.press}}"
Expand All @@ -41,9 +47,9 @@


{{#if showTitleInMenuButton}}
<h1 class="ui5-shellbar-menu-button-title">
<bdi>{{primaryTitle}}</bdi>
</h1>
<div class="ui5-shellbar-menu-button-title">
{{primaryTitle}}
</div>
{{/if}}

<span class="ui5-shellbar-menu-button-arrow"></span>
Expand Down
2 changes: 2 additions & 0 deletions packages/fiori/src/themes/ShellBar.css
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
@import "./InvisibleTextStyles.css";

:host(:not([hidden])) {
display: inline-block;
width: 100%;
Expand Down

0 comments on commit aba5fb5

Please sign in to comment.