Skip to content

Commit

Permalink
fix: use singular name
Browse files Browse the repository at this point in the history
  • Loading branch information
georgimkv committed May 26, 2022
1 parent c2ea2d5 commit c032808
Showing 1 changed file with 12 additions and 12 deletions.
24 changes: 12 additions & 12 deletions packages/main/src/Dialog.js
Original file line number Diff line number Diff line change
Expand Up @@ -291,12 +291,12 @@ class Dialog extends Popup {

onEnterDOM() {
super.onEnterDOM();
this._attachScreenResizeHandlers();
this._attachScreenResizeHandler();
}

onExitDOM() {
super.onExitDOM();
this._detachScreenResizeHandlers();
this._detachScreenResizeHandler();
}

/**
Expand All @@ -305,22 +305,22 @@ class Dialog extends Popup {
_resize() {
super._resize();

if (this._screenResizeHandlersAttached) {
if (this._screenResizeHandlerAttached) {
this._center();
}
}

_attachScreenResizeHandlers() {
if (!this._screenResizeHandlersAttached) {
_attachScreenResizeHandler() {
if (!this._screenResizeHandlerAttached) {
window.addEventListener("resize", this._screenResizeHandler);
this._screenResizeHandlersAttached = true;
this._screenResizeHandlerAttached = true;
}
}

_detachScreenResizeHandlers() {
if (this._screenResizeHandlersAttached) {
_detachScreenResizeHandler() {
if (this._screenResizeHandlerAttached) {
window.removeEventListener("resize", this._screenResizeHandler);
this._screenResizeHandlersAttached = false;
this._screenResizeHandlerAttached = false; // prevent dialog from repositioning during resizing
}
}

Expand Down Expand Up @@ -458,7 +458,7 @@ class Dialog extends Popup {
}

_resizeWithEvent(event) {
this._detachScreenResizeHandlers();
this._detachScreenResizeHandler();
this.addEventListener("ui5-before-close", this._revertSize);

const { top, left } = this.getBoundingClientRect(),
Expand Down Expand Up @@ -496,7 +496,7 @@ class Dialog extends Popup {
}

_attachMouseDragHandlers() {
this._detachScreenResizeHandlers();
this._detachScreenResizeHandler();

window.addEventListener("mousemove", this._dragMouseMoveHandler);
window.addEventListener("mouseup", this._dragMouseUpHandler);
Expand Down Expand Up @@ -595,7 +595,7 @@ class Dialog extends Popup {
}

_attachMouseResizeHandlers() {
this._detachScreenResizeHandlers();
this._detachScreenResizeHandler();

window.addEventListener("mousemove", this._resizeMouseMoveHandler);
window.addEventListener("mouseup", this._resizeMouseUpHandler);
Expand Down

0 comments on commit c032808

Please sign in to comment.