Skip to content

Commit

Permalink
fix(ui5-tabcontainer): make disabled tabs focusable in overflow (#5300)
Browse files Browse the repository at this point in the history
Fixes: 5131
  • Loading branch information
georgimkv authored Jun 1, 2022
1 parent 379cc7b commit c39917f
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion packages/main/src/Tab.js
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,7 @@ class Tab extends UI5Element {
classes.push(`ui5-tab-overflow-item--${this.design.toLowerCase()}`);
}

if (this.disabled) {
if (this.effectiveDisabled) {
classes.push("ui5-tab-overflow-item--disabled");
}

Expand Down
1 change: 0 additions & 1 deletion packages/main/src/TabInOverflow.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
id="{{this._id}}"
class="{{this.overflowClasses}}"
type="{{this.overflowState}}"
?disabled="{{this.effectiveDisabled}}"
aria-disabled="{{this.effectiveDisabled}}"
aria-selected="{{this.effectiveSelected}}"
aria-labelledby="{{this.ariaLabelledBy}}"
Expand Down
2 changes: 1 addition & 1 deletion packages/theming/css-vars-usage.json
Original file line number Diff line number Diff line change
Expand Up @@ -417,4 +417,4 @@
"--sapToolbar_SeparatorColor",
"--sapWarningBackground",
"--sapWarningBorderColor"
]
]

0 comments on commit c39917f

Please sign in to comment.