Skip to content

Commit

Permalink
fix(ui5-busyindicator): fix aria-labelledby value (#3266)
Browse files Browse the repository at this point in the history
Fixes: #3256
  • Loading branch information
TeodorTaushanov authored May 18, 2021
1 parent 0a33c40 commit ef2d332
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
2 changes: 1 addition & 1 deletion packages/main/src/BusyIndicator.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
aria-valuemin="0"
aria-valuemax="100"
aria-valuetext="Busy"
aria-labelledby="{{_id}}-label"
aria-labelledby="{{labelId}}"
>
<div class="ui5-busyindicator-circles-wrapper">
<div class="ui5-busyindicator-circle circle-animation-0"></div>
Expand Down
4 changes: 4 additions & 0 deletions packages/main/src/BusyIndicator.js
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,10 @@ class BusyIndicator extends UI5Element {
return this.i18nBundle.getText(BUSY_INDICATOR_TITLE);
}

get labelId() {
return this.text ? `${this._id}-label` : undefined;
}

get classes() {
return {
root: {
Expand Down

0 comments on commit ef2d332

Please sign in to comment.