Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BusyIndicator: ARIA attribute element ID does not exist on the page: aria-labelledby="ui5wc_XXX-label" #3256

Closed
sleric1024 opened this issue May 17, 2021 · 1 comment · Fixed by #3266
Closed

BusyIndicator: ARIA attribute element ID does not exist on the page: aria-labelledby="ui5wc_XXX-label" #3256

sleric1024 opened this issue May 17, 2021 · 1 comment · Fixed by #3266
Assignees
@TeodorTaushanov
Labels
approved This issue is approved bug This issue is a bug in the code Medium Prio TOPIC RD

Comments

@sleric1024
Copy link

Describe the bug
Ensures all ARIA attributes have valid values

Isolated Example
https://g00py.csb.app/

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'https://g00py.csb.app/'
  2. Open chrome element inspect or open the Chrome plugin axe-coconut
  3. check the label id from aria-labelledby attribute

Expected behavior
Ensures all ARIA attributes have valid values

Screenshots
image

UI5 Web Components for React Information
@ui5/webcomponents version: 1.0.0-rc.14
@ui5/webcomponents-react version: 0.15.4
Operating System: Mac OS
Browser: Chrome

Additional context
I am from SAP Successfactors
@Lukas742
Copy link
Collaborator

Hi @sleric1024

since the BusyIndicator is developed by the ui5-webcomponents team and the same behavior occurs when using pure webcomponents (see this example), I'm going to transfer this issue to their repo.

@Lukas742 Lukas742 transferred this issue from SAP/ui5-webcomponents-react May 17, 2021
@TeodorTaushanov TeodorTaushanov self-assigned this May 17, 2021
@TeodorTaushanov TeodorTaushanov added the bug This issue is a bug in the code label May 17, 2021
TeodorTaushanov added a commit that referenced this issue May 18, 2021
@TeodorTaushanov
fix(ui5-busyindicator): fixed aria-labelledby value
cb64deb 
Fixes #3256
@TeodorTaushanov TeodorTaushanov mentioned this issue May 18, 2021
Merged
TeodorTaushanov added a commit that referenced this issue May 18, 2021
@TeodorTaushanov
fix(ui5-busyindicator): fixed aria-labelledby value
ab51b4b 
Fixes #3256
ilhan007 pushed a commit that referenced this issue May 18, 2021
@TeodorTaushanov
fix(ui5-busyindicator): fix aria-labelledby value (#3266)
ef2d332 
Fixes: #3256
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TeodorTaushanov TeodorTaushanov

Labels
approved This issue is approved bug This issue is a bug in the code Medium Prio TOPIC RD
Projects
Maintenance - Topic RD
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-busyindicator): fixed aria-labelledby value SAP/ui5-webcomponents
3 participants
@sleric1024 @TeodorTaushanov @Lukas742