-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(framework): add JSX template support with TypeScript #10046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladitasev
approved these changes
Dec 11, 2024
pskelin
changed the title
feat: add TSX template support
feat(framework): add JSX template support with Typescript
Dec 12, 2024
pskelin
changed the title
feat(framework): add JSX template support with Typescript
feat(framework): add JSX template support with TypeScript
Dec 12, 2024
🎉 This PR is included in version v2.6.0-rc.0 🎉 The release is available on v2.6.0-rc.0 Your semantic-release bot 📦🚀 |
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSX templates
This change is introducing JSX support for web component templates with full TypeScript support. Main benefits include
Docs:
https://github.com/SAP/ui5-webcomponents/blob/f6ec6aba443e0e2dc048439e931361e1cf4b2c04/docs/4-development/08-templates.md
Status
eventDetails
to describe event names and event parameter typeseventDetails
(onSelectionChange={ (e) => { e.detail } }
)<ui5-button-scoped>
,ui5-selection-change
event)@bound
decorator for methods accessingthis
and dev checkthis
parameterkey={}
when iterating (items.map
)Record<string, boolean>
adding a class for each truthy valueref
to get a DOM node instanceJSX.AriaRole
?in follow up changes:
Size improvements
A note for component developers
If you are developing components, HBS support is deprecated, but will not be removed until the next major release. You should still consider migrating to JSX for the benefits listed above.
If you are extending components from this repo without modifying the template, you can just switch the renderer to JSXRenderer from LitRenderer and the rest remains the same.
If you are extending the templates of components from this repo (or others migrated to JSX), you will need to switch to JSX as well, since implementation of partials is specific to the templating technology.
Fixes: #7896