Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Step Input #2640

Closed
agauyeung opened this issue Jan 7, 2021 · 4 comments · Fixed by #2804
Closed

Step Input #2640

agauyeung opened this issue Jan 7, 2021 · 4 comments · Fixed by #2804
Assignees
@NHristov-sap
Labels
approved This issue is approved feature request High Prio Planned SAP SF TOPIC B
Milestone
1.0.0-rc.13

Comments

@agauyeung
Copy link

Is your feature request related to a problem? Please describe.
We need a number incrementer/decrementer.

Describe the solution you'd like
Please implement Step Input as detailed in the Fiori Documentation.

Describe alternatives you've considered
Input with type as Number. However, UX has told us that Step Input is easier to use on mobile screens.

Additional context
image
@ilhan007
Copy link
Member

ilhan007 commented Jan 8, 2021 •
edited
Loading

Hello @SAP/ui5-webcomponents-topic-b please consider this request with a highest priority.

This is the API we would like to support:

Properties

  • disabled
  • readonly
  • value
  • placeholder
  • min
  • max
  • step (with the default stepMode for openui5)
  • valueState

Slots

  • valueStateMessage(slot for custom message - see Input for reference)

Events:

  • change (due to focus out or increment/decrement buttons are used)

Screen Reader, Keyboard Handling, Theming and Sample as usual

Reference implementation
https://openui5nightly.hana.ondemand.com/entity/sap.m.StepInput

@ilhan007 ilhan007 added this to the 1.0.0-rc.13 milestone Jan 11, 2021
@ilhan007 ilhan007 added the approved This issue is approved label Jan 11, 2021
@agauyeung
Copy link
Author

Hi @NHristov-sap any updates on this?

@NHristov-sap NHristov-sap mentioned this issue Feb 10, 2021
Merged
@agauyeung
Copy link
Author

hi @NHristov-sap what is the timeline for releasing this?

@ilhan007
Copy link
Member

Hi @agauyeung

The timeline is RC.13, but it would be merged in few days.

Screenshot 2021-02-17 at 8 34 27 AM

Screenshot 2021-02-17 at 8 33 55 AM

ilhan007 pushed a commit that referenced this issue Feb 22, 2021
@NHristov-sap
feat(ui5-step-input): inintial implementation (#2804)
d80420e 
Fixes #2640
ilhan007 pushed a commit that referenced this issue Feb 25, 2021
@NHristov-sap @ilhan007
feat(ui5-step-input): inintial implementation (#2804)
00dcf47 
Fixes #2640
ilhan007 pushed a commit that referenced this issue Mar 29, 2021
@NHristov-sap @ilhan007
feat(ui5-step-input): inintial implementation (#2804)
4c340dd 
Fixes #2640
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NHristov-sap NHristov-sap

Labels
approved This issue is approved feature request High Prio Planned SAP SF TOPIC B
Projects
None yet
Milestone
1.0.0-rc.13
Development

Successfully merging a pull request may close this issue.

feat(ui5-step-input): inintial implementation SAP/ui5-webcomponents
4 participants
@agauyeung @DMihaylova @ilhan007 @NHristov-sap