Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiInput RTL Issues #2749

Closed
agauyeung opened this issue Jan 28, 2021 · 1 comment · Fixed by #2782
Closed

MultiInput RTL Issues #2749

agauyeung opened this issue Jan 28, 2021 · 1 comment · Fixed by #2782
Assignees
Labels
bug This issue is a bug in the code High Prio SAP SF TOPIC RL

Comments

@agauyeung
Copy link

Describe the bug
For ui5-multi-input, a user can view all tokens in a dropdown if the number of tokens exceed the width of the multi input. In RTL, the button to view the dropdown does not appear. Even if it does, it appears with the token names in the dropdown left-aligned.

To reproduce
Steps to reproduce the behavior:

  1. RTL
  2. Enter tokens until they exceed the width of the multi input
  3. **Issue: ** The more button does not appear most of the time.
  4. Even if it does,...click the " more" to view the token dropdown
  5. **Issue: ** The token names are improperly aligned in the dropdown

Isolated example
https://codesandbox.io/s/ui5-webcomponents-forked-q1455?file=/index.html

Expected behavior
" more should appear" when tokens exceed width.
Token names in the dropdown should be right-aligned.

Screenshots
image
image

Context

  • UI5 Web Components version "1.0.0-rc.11"

Organization: SuccessFactors

Priority: High - Is functional one and makes a single component almost unusable under certain circumstances.

@ilhan007
Copy link
Member

Hello @SAP/ui5-webcomponents-topic-rl could you look into RTL appearance of the MultiInput. It is reproducible here and in our test pages

Open https://sap.github.io/ui5-webcomponents/master/playground/main/pages/MultiInput/
set dir="rtl" to the body

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code High Prio SAP SF TOPIC RL
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

4 participants