Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Component: ui5-breadcrumbs #3166

Closed
ilhan007 opened this issue Apr 19, 2021 · 2 comments · Fixed by #3489
Closed

New Component: ui5-breadcrumbs #3166

ilhan007 opened this issue Apr 19, 2021 · 2 comments · Fixed by #3489

Comments

@ilhan007
Copy link
Member

ilhan007 commented Apr 19, 2021

Is your feature request related to a problem? Please describe.
We would like a component, that enables users to navigate between previous steps in the user's navigation path. For that we want to have Breadcrumb web component as part of the "main" library.

Screenshot 2021-04-19 at 17 13 07

Screenshot 2021-04-19 at 17 13 16

Features

  • overflow behaviour
  • support for different separator styles
  • screen reader - set the required aria attrs
  • keyboard handling - navigation between links, activation on SPACE/ENTER

separator style

UX
https://ux.wdf.sap.corp/fiori-design-web/breadcrumb/

Reference
https://openui5nightly.hana.ondemand.com/entity/sap.m.Breadcrumbs

API

  • default slot for "links"
  • property currentLocation
  • events - make sure there is event whenever the user clicks on link within the breadcrumbs or uses the overflow menu

Usage

<ui5-breadcrumbs current-location="Laptop">
   	<ui5-link>Products</ui5-link>
   		<ui5-link>Suppliers</ui5-link>
   			<ui5-link>Titanium</ui5-link>
</ui5-breadcrumbs>

Additional
Some points I did not consider, but you may take the time to:

  • slot type - Do we need a child component like ui5-breadcrumb, instead of using the ui5-link directly.

  • property current-location - Do we need such prop at all, or consider the last link added within the slot as the current location and just reuse its text

<ui5-breadcrumbs >
   	<ui5-link>Products</ui5-link>
   		<ui5-link>Suppliers</ui5-link>
   			<ui5-link>Titanium</ui5-link>
   			     <ui5-link>Laptop</ui5-link>
</ui5-breadcrumbs>
@ilhan007
Copy link
Member Author

ilhan007 commented Apr 19, 2021

FYI: @nnaydenow @jdichev

@nnaydenow
Copy link
Contributor

Internal reference: 5244

kineticjs added a commit to kineticjs/ui5-webcomponents that referenced this issue May 31, 2021
kineticjs added a commit to kineticjs/ui5-webcomponents that referenced this issue Jun 1, 2021
kineticjs added a commit to kineticjs/ui5-webcomponents that referenced this issue Jun 1, 2021
kineticjs added a commit to kineticjs/ui5-webcomponents that referenced this issue Jun 13, 2021
kineticjs added a commit to kineticjs/ui5-webcomponents that referenced this issue Jun 14, 2021
kineticjs added a commit to kineticjs/ui5-webcomponents that referenced this issue Jun 14, 2021
kineticjs added a commit to kineticjs/ui5-webcomponents that referenced this issue Jun 14, 2021
kineticjs added a commit to kineticjs/ui5-webcomponents that referenced this issue Jun 14, 2021
kineticjs added a commit to kineticjs/ui5-webcomponents that referenced this issue Jun 15, 2021
kineticjs added a commit to kineticjs/ui5-webcomponents that referenced this issue Jun 15, 2021
kineticjs added a commit to kineticjs/ui5-webcomponents that referenced this issue Jun 15, 2021
kineticjs added a commit to kineticjs/ui5-webcomponents that referenced this issue Jun 15, 2021
kineticjs added a commit to kineticjs/ui5-webcomponents that referenced this issue Jun 15, 2021
kineticjs added a commit to kineticjs/ui5-webcomponents that referenced this issue Jun 15, 2021
kineticjs added a commit to kineticjs/ui5-webcomponents that referenced this issue Jun 16, 2021
kineticjs added a commit to kineticjs/ui5-webcomponents that referenced this issue Jun 16, 2021
kineticjs added a commit to kineticjs/ui5-webcomponents that referenced this issue Jun 16, 2021
kineticjs added a commit to kineticjs/ui5-webcomponents that referenced this issue Jun 29, 2021
kineticjs added a commit to kineticjs/ui5-webcomponents that referenced this issue Jun 29, 2021
kineticjs added a commit to kineticjs/ui5-webcomponents that referenced this issue Jul 2, 2021
kineticjs added a commit to kineticjs/ui5-webcomponents that referenced this issue Jul 4, 2021
kineticjs added a commit to kineticjs/ui5-webcomponents that referenced this issue Jul 4, 2021
kineticjs added a commit to kineticjs/ui5-webcomponents that referenced this issue Jul 4, 2021
kineticjs added a commit to kineticjs/ui5-webcomponents that referenced this issue Jul 5, 2021
kineticjs added a commit to kineticjs/ui5-webcomponents that referenced this issue Jul 5, 2021
kineticjs added a commit to kineticjs/ui5-webcomponents that referenced this issue Jul 7, 2021
kineticjs added a commit to kineticjs/ui5-webcomponents that referenced this issue Jul 7, 2021
kineticjs added a commit to kineticjs/ui5-webcomponents that referenced this issue Jul 7, 2021
kineticjs added a commit to kineticjs/ui5-webcomponents that referenced this issue Jul 13, 2021
kineticjs added a commit to kineticjs/ui5-webcomponents that referenced this issue Jul 13, 2021
kineticjs added a commit to kineticjs/ui5-webcomponents that referenced this issue Jul 13, 2021
kineticjs added a commit to kineticjs/ui5-webcomponents that referenced this issue Jul 13, 2021
kineticjs added a commit to kineticjs/ui5-webcomponents that referenced this issue Jul 14, 2021
kineticjs added a commit to kineticjs/ui5-webcomponents that referenced this issue Jul 14, 2021
kineticjs added a commit to kineticjs/ui5-webcomponents that referenced this issue Jul 14, 2021
kineticjs added a commit to kineticjs/ui5-webcomponents that referenced this issue Jul 20, 2021
kineticjs added a commit to kineticjs/ui5-webcomponents that referenced this issue Jul 27, 2021
@ilhan007 ilhan007 modified the milestones: 1.0.0-rc.16, 1.0.0-rc.15 Aug 18, 2021
@petyabegovska petyabegovska moved this to 1.0.0-rc.15 (released Aug) in UI5 Web Components - Roadmap Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment