fix(ui5-popover): Calculate max content height #3386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #3131 This fix steps on the following commit: e35cc1a It enhances it in a way that Popover.MIN_OFFSET is taken into account into Popover's maxContentHeight. Popover.MIN_OFFSET is used when calculating the offset of the Popover from the top, but has never been extracted from the content's height.
georgimkv
approved these changes
Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3131
This fix steps on the following commit: e35cc1a
It enhances it in a way that Popover.MIN_OFFSET is taken into account into Popover's maxContentHeight. Popover.MIN_OFFSET is used when calculating the offset of the Popover from the top but has never been extracted from the content's height.