Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[URGENT][BUG][UI5-Table][UI5-List][Badge]Inner ui5-hidden-text element will result the error rendering of ui5-table, ui5-list in RTL mode #3503

Closed
sfsf-xweb-sh opened this issue Jul 14, 2021 · 4 comments · Fixed by #3948
Labels
bug This issue is a bug in the code High Prio SAP SF TOPIC Core

Comments

@sfsf-xweb-sh
Copy link

Dear colleagues,
I am from SuccessFactors Web Experience Shanghai team.

Bug Description:
Inner ui5-hidden-text element in Badge and ui5-li-groupheader will lead to the error rendering of ui5-table and ui5-list component in RTL mode. ui5-table and ui5-list will render the unnecessary scroll bar in RTL mode

Expected Behavior:
ui5-table and ui5-list will not render the unnecessary scroll bar in RTL mode

Reproduce step:

  1. goto https://github.wdf.sap.corp/pages/xweb/assignment/app.html?mock&sap-ui-rtl=true#/assignment-detail/ao/2
  2. switch to Applicants panel
  3. this website contains the source map

Screen Shot 2021-07-14 at 5 30 34 PM

Screen Shot 2021-07-14 at 1 30 52 PM

@vladitasev
Copy link
Contributor

Hello @sfsf-xweb-sh

Just opened the page and I can see no horizontal scrollbar:
image

I tried resizing or opening on phone, still I get no horizontal scrollbar.

Regards,
Vladi

@alexandar-mitsev alexandar-mitsev self-assigned this Jul 15, 2021
@alexandar-mitsev
Copy link
Contributor

Hi @SAP/ui5-webcomponents-team ,

I could reproduce the issue on Chrome on Windows.
The scroll really seems to appear because of the ui5-hidden-text styles. Specifically the left: -1000px. If replaced with right: -1000px for rtl the scroll is gone.

Regards,
Alex

@alexandar-mitsev alexandar-mitsev added bug This issue is a bug in the code High Prio SAP SF TOPIC Core labels Jul 15, 2021
@alexandar-mitsev alexandar-mitsev removed their assignment Jul 15, 2021
@sfsf-xweb-sh
Copy link
Author

sfsf-xweb-sh commented Jul 16, 2021

Hi @vladitasev @alexandar-mitsev

You can reproduce this bug on chrome

Regards,
XWeb Shanghai team

@ilhan007
Copy link
Member

Fixed with 0.31.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code High Prio SAP SF TOPIC Core
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

4 participants