Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree: Unnecessary scroll bar coming up in RTL mode. #3947

Closed
SriramParamasivam opened this issue Sep 16, 2021 · 9 comments · Fixed by #3948 or #4085
Closed

Tree: Unnecessary scroll bar coming up in RTL mode. #3947

SriramParamasivam opened this issue Sep 16, 2021 · 9 comments · Fixed by #3948 or #4085

Comments

@SriramParamasivam
Copy link

Describe the bug
Unnecessary scroll bar coming up in RTL mode.

Isolated Example
https://sap.github.io/ui5-webcomponents-react/?path=/docs/data-display-tree--default-story&globals=direction:rtl

To Reproduce
Steps to reproduce the behavior:

  1. Go to Tree component https://sap.github.io/ui5-webcomponents-react/?path=/docs/data-display-tree--default-story&globals=direction:rtl
  2. See unwanted scrollbar showing up even though the text is not longer.

Expected behavior
Scrollbar should not come.

Screenshots
image

UI5 Web Components for React Information
@ui5/webcomponents version: 0.31.16
@ui5/webcomponents-react version: 0.131.18
Operating System:
Browser:

Additional context
Add any other context about the problem here.

@MarcusNotheis
Copy link
Collaborator

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

@MarcusNotheis MarcusNotheis transferred this issue from SAP/ui5-webcomponents-react Sep 17, 2021
@ilhan007
Copy link
Member

Hello @SAP/ui5-webcomponents-topic-p could you take a look of this issue. The issue itself is not that severe, but the priority is high, because of the short deadline for resolving.

@PetyaMarkovaBogdanova PetyaMarkovaBogdanova self-assigned this Sep 17, 2021
@georgimkv
Copy link
Contributor

This issue is caused by the invisible text, which is also an issue in SideNavigation and List, when in RTL mode. #3503

@ilhan007
Copy link
Member

Fixed with 0.31.18

@ilhan007 ilhan007 reopened this Oct 4, 2021
@ilhan007 ilhan007 closed this as completed Oct 4, 2021
@SriramParamasivam
Copy link
Author

This issue still happening in MultiSelect Mode. Please have a look at this Code sandbox, https://codesandbox.io/s/eager-wu-7wr8r?file=/src/App.js

Thanks,
Sriram Paramasivam

@ilhan007
Copy link
Member

ilhan007 commented Oct 7, 2021

Hello @PetyaMarkovaBogdanova

the issue seems to be reproducible after the fix, see the sample:
https://codesandbox.io/s/eager-wu-7wr8r?file=/src/App.js

The sample uses version 0.31.20 and it includes the fix (the fix has been downported and available since 0.31.18).

Here is the downported change.

Could you once again investigate the issue?

@nnaydenow
Copy link
Contributor

Hi @SriramParamasivam,

Could you check again? I'm not able to reproduce the issue.

Regards,
Nayden

@nnaydenow
Copy link
Contributor

Hi @SriramParamasivam ,

Just pinging you to know that I reproduced the issue.

ilhan007 pushed a commit that referenced this issue Oct 16, 2021
…de (#4085)

Unnecessary scrollbar that appeared in RTL mode of ui5-list is now removed.

Fixes: #3947
ilhan007 pushed a commit that referenced this issue Oct 16, 2021
…de (#4085)

Unnecessary scrollbar that appeared in RTL mode of ui5-list is now removed.

Fixes: #3947
@ilhan007 ilhan007 reopened this Oct 16, 2021
@ilhan007
Copy link
Member

Hello @SriramParamasivam the fix is released with v0.31.21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment