-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui5-flexible-column-layout: [AXE error] All page content should be contained by landmarks #3804
Comments
Hello, we discussed this on our accessibility sync and we will add the role region to the arrow button containers. |
@nnaydenow I guess you need to move the item to "Approved" |
Hi @GongRichard, Would it be enough for you if we set a role region on the arrow buttons containers or would you prefer if we offer an API to be able to customise the roles? Also, setting a landmark roles on those containers would also require them to have an unique labels. Would you prefer to be able to set custom labels? We will further discuss the default labels with our UX team but let us know if you prefer any default values. |
@dobrinyonkov You can have default roles and labels and also provide API to customize roles and labels. |
) * feat(ui5-flexible-column-layout): new property accessibilityRoles Summary: 1. New property accessibilityRoles added to set custom roles on the containers (start/mid/end column + arrow containers) 2. Add 2 additional properties to the accessibilityTexts object to set custom labels on the arrow containers) Fixes: #3804, #3796
…P#4446) * feat(ui5-flexible-column-layout): new property accessibilityRoles Summary: 1. New property accessibilityRoles added to set custom roles on the containers (start/mid/end column + arrow containers) 2. Add 2 additional properties to the accessibilityTexts object to set custom labels on the arrow containers) Fixes: SAP#3804, SAP#3796
Hello @GongRichard the issue will be resolved with 1.1.0 - will be available by the end of the day |
Bug Description
For our application, the mid column is the main content, so we set role="main" to the mid-column slot. So there is no landmark for the arrow button and some hidden text.
Expected Behavior
All page content should be contained by landmarks.
Steps to Reproduce
Context
Log Output / Stack Trace / Screenshots
Priority
The priority indicates the severity of the issue. To set the appropriate priority consider the following criteria:
Note: The priority might be re-evaluated by the issue processor.
Stakeholder Info (if applicable)
The text was updated successfully, but these errors were encountered: