Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui5-flexible-column-layout: [AXE error] All page content should be contained by landmarks #3804

Closed
1 of 4 tasks
GongRichard opened this issue Sep 2, 2021 · 5 comments · Fixed by #4446
Closed
1 of 4 tasks

Comments

@GongRichard
Copy link

GongRichard commented Sep 2, 2021

Bug Description

For our application, the mid column is the main content, so we set role="main" to the mid-column slot. So there is no landmark for the arrow button and some hidden text.

Expected Behavior

All page content should be contained by landmarks.

Steps to Reproduce

  1. Go to https://github.wdf.sap.corp/pages/xweb/goalmanagementx/app.html?mock&noFirstTimeGuidance
  2. Run AXE plugin
  3. There has four moderate errors "All page content should be contained by landmarks"

Context

  • UI5 Web Components version: {0.31.12}
  • OS/Platform: {MacOS}
  • Browser: {Chrome}
  • Affected component: {ui5-flexible-column-layout}

Log Output / Stack Trace / Screenshots

2021-09-02_15-42-16
2021-09-02_15-43-06

Priority

  • Low
  • Medium
  • High
  • Very High

The priority indicates the severity of the issue. To set the appropriate priority consider the following criteria:

  • Breaks entire application or system - High or Very High
  • Accessibility issue - Medium or High
  • Functional issue - Medium or High
  • Visual issue - Low or Medium

Note: The priority might be re-evaluated by the issue processor.

Stakeholder Info (if applicable)

  • Organization: {SAP Successfators}
@dobrinyonkov dobrinyonkov self-assigned this Sep 3, 2021
@dobrinyonkov dobrinyonkov added the enhancement New feature or request label Sep 3, 2021
@ilhan007 ilhan007 assigned jdichev and nnaydenow and unassigned jdichev and nnaydenow Nov 17, 2021
@dobrinyonkov
Copy link
Contributor

Hello, we discussed this on our accessibility sync and we will add the role region to the arrow button containers.

@ilhan007
Copy link
Member

@nnaydenow I guess you need to move the item to "Approved"

@dobrinyonkov
Copy link
Contributor

Hi @GongRichard,

Would it be enough for you if we set a role region on the arrow buttons containers or would you prefer if we offer an API to be able to customise the roles?

Also, setting a landmark roles on those containers would also require them to have an unique labels. Would you prefer to be able to set custom labels? We will further discuss the default labels with our UX team but let us know if you prefer any default values.

@GongRichard
Copy link
Author

GongRichard commented Nov 23, 2021

@dobrinyonkov You can have default roles and labels and also provide API to customize roles and labels.

dobrinyonkov added a commit to dobrinyonkov/ui5-webcomponents that referenced this issue Dec 7, 2021
Summary:
1. New property accessibilityRoles added to set custom roles on the containers (start/mid/end column + arrow containers)
2. Add 2 additional properties to the accessibilityTexts object to set custom labels on the arrow containers)

Fixes: SAP#3804, SAP#3796
@ilhan007 ilhan007 added this to the 1.1.0 milestone Dec 15, 2021
dobrinyonkov added a commit that referenced this issue Dec 17, 2021
)

* feat(ui5-flexible-column-layout): new property accessibilityRoles

Summary:
1. New property accessibilityRoles added to set custom roles on the containers (start/mid/end column + arrow containers)
2. Add 2 additional properties to the accessibilityTexts object to set custom labels on the arrow containers)

Fixes: #3804, #3796
eshpak pushed a commit to eshpak/ui5-webcomponents that referenced this issue Jan 9, 2022
…P#4446)

* feat(ui5-flexible-column-layout): new property accessibilityRoles

Summary:
1. New property accessibilityRoles added to set custom roles on the containers (start/mid/end column + arrow containers)
2. Add 2 additional properties to the accessibilityTexts object to set custom labels on the arrow containers)

Fixes: SAP#3804, SAP#3796
@ilhan007
Copy link
Member

Hello @GongRichard the issue will be resolved with 1.1.0 - will be available by the end of the day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed
Status: Q1, 1.1.0 Jan 2022
Development

Successfully merging a pull request may close this issue.

7 participants