Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Data Text for Table Component #389

Closed
gustavokath opened this issue May 15, 2019 · 3 comments · Fixed by #402
Closed

No Data Text for Table Component #389

gustavokath opened this issue May 15, 2019 · 3 comments · Fixed by #402

Comments

@gustavokath
Copy link
Contributor

In the table component, I'm missing the ability to set a specific text when there is no data to be loaded. Like in the UI5 we have the property noDataText for the component sap.m.Table or others like it. The current behavior is letting an empty table, that might not clarify what is going on to the user.

I've tried also to use only one ui5-table-row with a ui5-table-cell inside it and change its colspan and other properties to fill all header spaces I have in my table. But it does not work, It does not render right the table component.

So I want to rise this to you and discuss what would be the best approach to this issue.

@MapTo0
Copy link
Member

MapTo0 commented May 15, 2019

Hey @gustavokath

As much as I understand your issue, there are two things reported here:

  • feature request for noDataText
  • Some layouting issue with the row and cell

I would suggest that we collaborate and discuss these two.

No Data Text
Sounds good to me. Do you expect some default text or you want to have it always outside the component as an API?

Issue
Could you please help us and provide your use case as an example?
Starting point: https://codesandbox.io/s/v0wpm101k3

@gustavokath
Copy link
Contributor Author

gustavokath commented May 15, 2019

Hi @MapTo0

For the request for noDataText what I think that would be the best solution to me is to provide a way to pass a string to a component attribute where I can inform the string I expect.

The issue, came present when I tried to make an workaround the add one cell line in table the fills the full row. I'll add what I've tried to do in the link you provided me. Bellow the web component I added the behavior I would like to do in pure html

@gustavokath
Copy link
Contributor Author

Hi @MapTo0
I've made a suggested solution in PR #402.
Let me know if this proposed solution would be a good feature to add to the ui5-table component.
Also, feel free to add any feedbacks

ilhan007 pushed a commit that referenced this issue Jun 4, 2019
 - Added property `no-data-text` for storing the text that will be displayed
 - Added property `show-no-data` to check if no data text should be displayed
- Fixes #389
ilhan007 pushed a commit that referenced this issue Jun 6, 2019
 - Added property `no-data-text` for storing the text that will be displayed
 - Added property `show-no-data` to check if no data text should be displayed
- Fixes #389
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants