Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui5-card: card with list issue #4450

Closed
1 of 4 tasks
LidiyaGeorgieva opened this issue Dec 8, 2021 · 2 comments · Fixed by #4473
Closed
1 of 4 tasks

ui5-card: card with list issue #4450

LidiyaGeorgieva opened this issue Dec 8, 2021 · 2 comments · Fixed by #4473
Assignees
@plamenivanov91
Labels
bug This issue is a bug in the code Medium Prio TOPIC P

Comments

@LidiyaGeorgieva
Copy link
Contributor

Bug Description

Rows are not positioned correctly (vertically)
image

Steps to Reproduce

  1. Go to 'playground'
    Reproducible for Desktop & Phone, in LTR

Priority

  • Low
  • Medium
  • High
  • Very High
@LidiyaGeorgieva LidiyaGeorgieva added bug This issue is a bug in the code TOPIC RD labels Dec 8, 2021
@LidiyaGeorgieva LidiyaGeorgieva changed the title ui5-card: ui5-card: card with list issue Dec 8, 2021
@LidiyaGeorgieva LidiyaGeorgieva self-assigned this Dec 9, 2021
@LidiyaGeorgieva
Copy link
Contributor Author

Hello,

There is an issue with the custom list item.
It has height set, which causes issues when there is content on two or three rows inside.
It gets worse when there is Compact content density.
Example: https://jsbin.com/qemejimuqo/edit?html,output

Best Regards,
Lidiya

@georgimkv
Copy link
Contributor

FYI @SAP/ui5-webcomponents-topic-p

@plamenivanov91 plamenivanov91 self-assigned this Dec 10, 2021
plamenivanov91 added a commit to plamenivanov91/ui5-webcomponents that referenced this issue Dec 10, 2021
@plamenivanov91
fix(ui5-li-custom): removed height restriction
89e4940 
CustomListItem is no longer restricted to a hardcoded height. Now it
aligns its height depending on its content.

fixes: SAP#4450
@plamenivanov91 plamenivanov91 mentioned this issue Dec 10, 2021
Merged
2 tasks
plamenivanov91 added a commit that referenced this issue Dec 13, 2021
@plamenivanov91
fix(ui5-li-custom): removed height restriction (#4473)
e76f8c9 
* fix(ui5-li-custom): removed height restriction

CustomListItem is no longer restricted to a hardcoded height. Now it
aligns its height depending on its content.

fixes: #4450

* now the CLI has minimum height set to the LI base height
eshpak pushed a commit to eshpak/ui5-webcomponents that referenced this issue Jan 9, 2022
@plamenivanov91 @eshpak
fix(ui5-li-custom): removed height restriction (SAP#4473)
a2b7d22 
* fix(ui5-li-custom): removed height restriction

CustomListItem is no longer restricted to a hardcoded height. Now it
aligns its height depending on its content.

fixes: SAP#4450

* now the CLI has minimum height set to the LI base height
@petyabegovska petyabegovska moved this to Completed in Maintenance - Topic P Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plamenivanov91 plamenivanov91

Labels
bug This issue is a bug in the code Medium Prio TOPIC P
Projects
Maintenance - Topic P
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-li-custom): removed height restriction plamenivanov91/ui5-webcomponents
3 participants
@LidiyaGeorgieva @plamenivanov91 @georgimkv