Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SF][A11y][FlexibleColumnLayout] Last column region present on the page but visually there is no such region #4789

Closed
1 of 4 tasks
2bno1 opened this issue Feb 21, 2022 · 1 comment · Fixed by #4811
Closed
1 of 4 tasks
Assignees
Labels
bug This issue is a bug in the code Medium Prio SAP SF SF_ACC

Comments

@2bno1
Copy link

2bno1 commented Feb 21, 2022

Bug Description

Last column region is still present even I didn't specify endColumn slot.

Expected Behavior

Last column region should not be present if it's not specified.

Steps to Reproduce

  1. Go to https://codesandbox.io/s/flex-column-layout-wc-bpn692?file=/public/index.html
  2. Open inspector
  3. Note that last column region is present
    Screen Shot 2022-02-21 at 5 50 49 PM

Isolated Example

https://codesandbox.io/s/flex-column-layout-wc-bpn692?file=/public/index.html

Context

  • UI5 Web Components version: latest
  • OS/Platform: macOS
  • Browser: Chrome
  • Affected component: FlexibleColumnLayout

Priority

  • Low
  • Medium
  • High
  • Very High

The priority indicates the severity of the issue. To set the appropriate priority consider the following criteria:

  • Breaks entire application or system - High or Very High
  • Accessibility issue - Medium or High
  • Functional issue - Medium or High
  • Visual issue - Low or Medium

Note: The priority might be re-evaluated by the issue processor.

@dobrinyonkov dobrinyonkov self-assigned this Feb 21, 2022
@dobrinyonkov
Copy link
Contributor

dobrinyonkov commented Feb 21, 2022

Hello @SAP/ui5-webcomponents-topic-p,

The div wrappers for the columns slots are rendered even if the slots are not defined. Those divs are with role region which may be invalid from accessiblity POV.

We should remove the role attribute or even not render the empty divs, if possible.

Regards,
Dobrin

@dobrinyonkov dobrinyonkov added bug This issue is a bug in the code Medium Prio labels Feb 21, 2022
@dobrinyonkov dobrinyonkov removed their assignment Feb 21, 2022
@dobrinyonkov dobrinyonkov self-assigned this Feb 23, 2022
ilhan007 pushed a commit that referenced this issue Feb 24, 2022
…4811)

Hidden columns are rendered in the DOM but not visible to the users, so they should be hidden from the accessibility tree. Changes: remove the role attribute and set aria-hidden to true.

Fixes: #4789
ilhan007 pushed a commit that referenced this issue Mar 18, 2022
…4811)

Hidden columns are rendered in the DOM but not visible to the users, so they should be hidden from the accessibility tree. Changes: remove the role attribute and set aria-hidden to true.

Fixes: #4789
@petyabegovska petyabegovska moved this to Completed in Maintenance - Topic P Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Medium Prio SAP SF SF_ACC
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

3 participants