Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SF][1.2.1][ui5-flexible-column-layout][BUG][Urgent-Expected WithIn Two week]column vertical border is not right in hcb theme with RTL #4906

Closed
sfsf-xweb-sh opened this issue Mar 16, 2022 · 2 comments · Fixed by #4919
Assignees
Labels
bug This issue is a bug in the code SAP SF TOPIC P

Comments

@sfsf-xweb-sh
Copy link

Dear colleagues

I am from SuccessFactors Web Experience Shanghai team.

Bug Description

The version of ui5-webcomponents is 1.2.1

ui5-flexible-column-layout component's column vertical border is not right in hcb theme with RTL.

Screen Shot 2022-03-16 at 5 58 30 PM

Start column have a border-right and Middle column have a border-left in RTL.

Screen Shot 2022-03-16 at 6 07 16 PM

Screen Shot 2022-03-16 at 6 09 59 PM

Expected Behavior

Start column have a border-left not border-right and Middle column have a border-left not border-right in RTL.

Screen Shot 2022-03-16 at 6 19 04 PM

Steps to Reproduce

  1. open this link

Organization: SFSF

@ilhan007 ilhan007 added SAP SF TOPIC P bug This issue is a bug in the code labels Mar 16, 2022
@ilhan007
Copy link
Member

ilhan007 commented Mar 16, 2022

Hello @SAP/ui5-webcomponents-topic-b the issue is reproducible, It looks like we need to mirror these styles in RTL, but you need to check

:host([_visible-columns="2"]) .ui5-fcl-column--start {
	border-right: var(--_ui5_fcl_column_border);
}

:host([_visible-columns="3"]) .ui5-fcl-column--start {
	border-right: var(--_ui5_fcl_column_border);
}

:host([_visible-columns="2"]) .ui5-fcl-column--middle {
	border-left: var(--_ui5_fcl_column_border)
}

:host([_visible-columns="3"]) .ui5-fcl-column--middle {
	border-left: var(--_ui5_fcl_column_border)
}

:host([_visible-columns="3"]) .ui5-fcl-column--middle {
	border-right: var(--_ui5_fcl_column_border)
}

:host([_visible-columns="3"]) .ui5-fcl-column--end {
	border-left: var(--_ui5_fcl_column_border);
}

@sfsf-xweb-sh
Copy link
Author

Hello, @ilhan007
Our project code freeze is at April 1. I wonder if this issue will be resolved before that day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code SAP SF TOPIC P
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

3 participants