Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiComboBox gets an ugly additional scroll bar in its drop down with content density = cozy #5126

Closed
vlad-ti opened this issue Apr 26, 2022 · 5 comments · Fixed by #5216
Closed
Assignees
Labels
bug This issue is a bug in the code Medium Prio TOPIC RL

Comments

@vlad-ti
Copy link

vlad-ti commented Apr 26, 2022

Describe the bug
see bug title

To Reproduce
Go to: https://sap.github.io/ui5-webcomponents-react/?path=/docs/inputs-multicombobox--default-story
Select content density = cozy
When Click on the MultiComboBox sample to open its drop down list
Then you will see the ugly scroll bar
When you make the browser window small enough, so that not MultiBomboBoxItems can be shown at once in the dropdown menu
Then you will see the true scroll bar of the drop down + plus the second ugly looking one.

Expected behavior
The ugly looking scroll should not appear

Screenshots
bug MultiComboBox2
bug MultiComboBox1

UI5 Web Components for React Information
@ui5/webcomponents version: 0.23.0
@ui5/webcomponents-react version: 0.23.0
Operating System: Windows
Browser: Chrome

Additional context
The problem did not exist in 0.21.5

@vlad-ti vlad-ti added the bug This issue is a bug in the code label Apr 26, 2022
@MarcusNotheis
Copy link
Collaborator

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

@MarcusNotheis MarcusNotheis transferred this issue from SAP/ui5-webcomponents-react Apr 26, 2022
@ilhan007 ilhan007 removed the bug This issue is a bug in the code label Apr 27, 2022
@unazko unazko added bug This issue is a bug in the code TOPIC RL Medium Prio labels Apr 27, 2022
@unazko
Copy link
Contributor

unazko commented Apr 27, 2022

Hello @SAP/ui5-webcomponents-topic-rl,

The issue is reproducible via the described by @vlad-ti steps and in the react playground sample.
In order to reproduce the double vertical scrollbar issue you would have to reduce the browser window height so that when the
ui5-multi-combobox select dialog gets opened it won't have enough space to display fully in the window.

Best Regards,
Boyan Rakilovski

@MFel0123
Copy link

MFel0123 commented May 4, 2022

Hello ui5-webcomponent colleagues,
I can only confirm that we also see the ugly scrollbar(s) in our app- exactly as you described it here. Seems that we cannot easily get rid of them on our own.
If you can treat this with a higher priority we would be very happy. And the customers as well, for sure.
Best Regards
Matthias

@MapTo0 MapTo0 self-assigned this May 9, 2022
@MapTo0
Copy link
Member

MapTo0 commented May 9, 2022

Dear @MFel0123 @vlad-ti

Could you please assist reproducing this in a isolated example so I can speed up processing?
Starting point: https://codesandbox.io/s/nifty-allen-xeboby?file=/index.html

Regards,
Martin

@MFel0123
Copy link

Hello Martin,
as described above there is already an example given by @vlad-ti in the description.
You can also directly see it here: https://sap.github.io/ui5-webcomponents/playground/components/MultiComboBox/
Then go to the "MultiComboBox with items". Open it and you see the unneeded scrollbar.

press on this scrollbar, open "inspect" in the debugger tools and add 2px in the height of the corresponding ui5-list element. Then the scrollbar is gone. It seem that these 2px are missing.

Best Regards
Matthias

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Medium Prio TOPIC RL
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

6 participants