Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

item navigation: keyboard navigation is incorrect in RTL #5166

Closed
1 of 4 tasks
georgimkv opened this issue May 4, 2022 · 1 comment · Fixed by #5408
Closed
1 of 4 tasks

item navigation: keyboard navigation is incorrect in RTL #5166

georgimkv opened this issue May 4, 2022 · 1 comment · Fixed by #5408
Assignees
@georgimkv
Labels
bug This issue is a bug in the code Medium Prio TOPIC Core

Comments

@georgimkv
Copy link
Contributor

georgimkv commented May 4, 2022 •
edited
Loading

Bug Description

We use the ItemNavigation module in TabContainer and I noticed that the left/right arrow keys are behaving in reverse while in RTL mode.

Expected Behavior

Arrow Left should focus the item to the left, regardless of the LTR/RTL language being loaded.
This applies for Arrow right key too.

Steps to Reproduce

  1. Go to https://sap.github.io/ui5-webcomponents/playground/components/TabContainer/?sap-ui-theme=sap_fiori_3&isrtl=true
  2. Focus on a tab
  3. Navigate with the arrow keys.

The example is showing a TabContainer, but this would apply to all users of ItemNavigation in RTL.

Priority

  • Low
  • Medium
  • High
  • Very High
@georgimkv georgimkv mentioned this issue May 4, 2022
Closed
4 tasks
@IlianaB IlianaB added bug This issue is a bug in the code TOPIC Core Medium Prio labels May 4, 2022
@IlianaB
Copy link
Member

IlianaB commented May 4, 2022

Hello @SAP/ui5-webcomponents-topic-core I am forwarding this issue to you, because in RTL mode navigating with arrow keys (left/right) does not work as expected, but in the opposite way. It seems the problem comes from the ItemNavigation.

Could you take a look?

Regards,
Iliana

georgimkv added a commit that referenced this issue Jun 24, 2022
@georgimkv
fix(framework): correct use of arrow keys for ItemNavigation in RTL
a7bac7f 
In RTL, the left and right arrow keys now correctly move the focus for
horizontally navigable items.

Fixes: #5166
@georgimkv georgimkv mentioned this issue Jun 24, 2022
Merged
@georgimkv georgimkv self-assigned this Jun 24, 2022
georgimkv added a commit that referenced this issue Jun 30, 2022
@georgimkv
fix(framework): correct use of arrow keys for ItemNavigation in RTL (#…
cec8119 
…5408)

In RTL, the left and right arrow keys now correctly move the focus for
horizontally navigable items.

Fixes: #5166
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@georgimkv georgimkv

Labels
bug This issue is a bug in the code Medium Prio TOPIC Core
Projects
Maintenance - Topic Core
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(framework): correct use of arrow keys for ItemNavigation in RTL SAP/ui5-webcomponents
2 participants
@IlianaB @georgimkv