feat(ui5-multi-combobox): introduce grouping functionality #5250
Conversation
| * @tagname ui5-mcb-group-item | ||
| * @public | ||
| * @implements sap.ui.webcomponents.main.IMultiComboBoxItem | ||
| * @since 1.0.0-rc.15 |
| @@ -1055,7 +1057,29 @@ class MultiComboBox extends UI5Element { | |||
| } | |||
|
|
|||
| _filterItems(str) { | |||
| return (Filters[this.filter] || Filters.StartsWithPerTerm)(str, this.items); | |||
| const itemsToFilter = this.items.filter(item => !item.isGroupItem); | |||
There was a problem hiding this comment.
At first glance it looks a little complicated these two methods.
Something that might help to look more straightforward is to build a map or other structure (probably onBeforeRendering) to store the connection between items and the groups they belong. And, when the user filters, it will be much less code, more readable, to get from that structure which group items should be displayed for which items that remained after filtering. But, this is more for the team review.
There was a problem hiding this comment.
I think the same, Can we change the filters files to consider group items as that is implemented in both CB and MCB components?
There was a problem hiding this comment.
as all combobox / mcb items and group items all implement the IComboBoxItem can we introduce a method e.g. #isGroupItem? or something like this?
|
And there is a merge conflict packages/main/test/pages/MultiComboBox.html to be resolved |
| * | ||
| * @private | ||
| */ | ||
| static _groupItemFilter(item, idx, allItems, filteredItems) { |
There was a problem hiding this comment.
Rename the idx param to nextItemIdx for readibility
FIXES: #5060