feat(ui5-multi-combobox): introduce grouping functionality #5250
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| import UI5Element from "@ui5/webcomponents-base/dist/UI5Element.js"; | ||
| import GroupHeaderListItem from "./GroupHeaderListItem.js"; | ||
|
|
||
| /** | ||
| * @public | ||
| */ | ||
| const metadata = { | ||
| tag: "ui5-mcb-group-item", | ||
| properties: /** @lends sap.ui.webcomponents.main.MultiComboBoxGroupItem.prototype */ { | ||
| /** | ||
| * Defines the text of the component. | ||
| * | ||
| * @type {string} | ||
| * @defaultvalue "" | ||
| * @public | ||
| */ | ||
| text: { | ||
| type: String, | ||
| }, | ||
| }, | ||
| slots: /** @lends sap.ui.webcomponents.main.MultiComboBoxGroupItem.prototype */ { | ||
| }, | ||
| events: /** @lends sap.ui.webcomponents.main.MultiComboBoxGroupItem.prototype */ { | ||
| }, | ||
| }; | ||
|
|
||
| /** | ||
| * @class | ||
| * The <code>ui5-multi-combobox-group-item</code> is type of suggestion item, | ||
| * that can be used to split the <code>ui5-multi-combobox</code> suggestions into groups. | ||
| * | ||
| * @constructor | ||
| * @author SAP SE | ||
| * @alias sap.ui.webcomponents.main.MultiComboBoxGroupItem | ||
| * @extends UI5Element | ||
| * @tagname ui5-mcb-group-item | ||
| * @public | ||
| * @implements sap.ui.webcomponents.main.IMultiComboBoxItem | ||
| * @since 1.4.0 | ||
| */ | ||
| class MultiComboBoxGroupItem extends UI5Element { | ||
| static get metadata() { | ||
| return metadata; | ||
| } | ||
|
|
||
| static get dependencies() { | ||
| return [ | ||
| GroupHeaderListItem, | ||
| ]; | ||
| } | ||
|
|
||
| /** | ||
| * Used to avoid tag name checks | ||
| * @protected | ||
| */ | ||
| get isGroupItem() { | ||
| return true; | ||
| } | ||
|
|
||
| get stableDomRef() { | ||
| return this.getAttribute("stable-dom-ref") || `${this._id}-stable-dom-ref`; | ||
| } | ||
| } | ||
|
|
||
| MultiComboBoxGroupItem.define(); | ||
|
|
||
| export default MultiComboBoxGroupItem; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At first glance it looks a little complicated these two methods.
Something that might help to look more straightforward is to build a map or other structure (probably onBeforeRendering) to store the connection between items and the groups they belong. And, when the user filters, it will be much less code, more readable, to get from that structure which group items should be displayed for which items that remained after filtering. But, this is more for the team review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the same, Can we change the filters files to consider group items as that is implemented in both CB and MCB components?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as all combobox / mcb items and group items all implement the
IComboBoxItemcan we introduce a method e.g.#isGroupItem?or something like this?