Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertically resizing window does not recenter the Dialog in 1.3.X #5259

Closed
1 of 4 tasks
codefactor opened this issue May 20, 2022 · 2 comments · Fixed by #5283
Closed
1 of 4 tasks

Vertically resizing window does not recenter the Dialog in 1.3.X #5259

codefactor opened this issue May 20, 2022 · 2 comments · Fixed by #5283
Assignees
Labels
bug This issue is a bug in the code Medium Prio SAP SF TOPIC RD

Comments

@codefactor
Copy link
Contributor

Bug Description

The Dialog does not recenter if you resize the window vertically.

Expected Behavior

The Dialog should recenter/resize when you resize the window.

Steps to Reproduce

  1. Go to https://sap.github.io/ui5-webcomponents/playground/components/Dialog/
  2. Open the dialog
  3. Resize the window, but only vertically

Isolated Example

Not necessary - it's easily reproduced.

Context

  • UI5 Web Components version: 1.3.X

Log Output / Stack Trace / Screenshots

Priority

  • Low
  • Medium
  • High
  • Very High

The priority indicates the severity of the issue. To set the appropriate priority consider the following criteria:

  • Breaks entire application or system - High or Very High
  • Accessibility issue - Medium or High
  • Functional issue - Medium or High
  • Visual issue - Low or Medium

Note: The priority might be re-evaluated by the issue processor.

Stakeholder Info (if applicable)

  • Organization: SuccessFactors
  • Business impact: {...}
@terezamch terezamch self-assigned this May 23, 2022
@terezamch terezamch added bug This issue is a bug in the code TOPIC RD Medium Prio labels May 23, 2022
@terezamch
Copy link
Contributor

Hello @SAP/ui5-webcomponents-topic-rd,

When resizing the browser window vertically, the Dialog doesn't resize properly, which can be observed in the playground https://sap.github.io/ui5-webcomponents/playground/components/Dialog/.
When the window is resized to smaller than the Dialog size - the headers gets cut and hidden. When the window is resized back - the Dialog does not get to the initial position.

Best regards,
Tereza

@terezamch terezamch removed their assignment May 23, 2022
@georgimkv georgimkv self-assigned this May 23, 2022
@codefactor
Copy link
Contributor Author

Any update on this?

This seems like a major regression issue to me.

georgimkv added a commit that referenced this issue May 26, 2022
When the body element is shorter in height than the screen size,
resizing the browser window in height would not trigger a resize
event on the body, and the dialog will not be repositioned.

To solve this case, the dialog has been changed to listen to the resize
event on the window.

Fixes: #5259
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Medium Prio SAP SF TOPIC RD
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

4 participants