Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

badge: icon only badge has incorrect padding #5328

Closed
georgimkv opened this issue Jun 6, 2022 · 0 comments · Fixed by #5334
Closed

badge: icon only badge has incorrect padding #5328

georgimkv opened this issue Jun 6, 2022 · 0 comments · Fixed by #5334
Assignees
@dimovpetar
Labels
bug This issue is a bug in the code Medium Prio TOPIC RD

Comments

@georgimkv
Copy link
Contributor

georgimkv commented Jun 6, 2022 •
edited
Loading

A recent pull request, #4356 introduced a regression where the whitespace for a badge with only an icon has changed and the icon is not centered.
In latest stable release:
image

In main branch:
image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dimovpetar dimovpetar

Labels
bug This issue is a bug in the code Medium Prio TOPIC RD
Projects
Maintenance - Topic RD
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-badge): correctly detect if default slot is provided SAP/ui5-webcomponents
2 participants
@georgimkv @dimovpetar