Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(popup): remove body styles in onExitDOM #593

Merged
merged 6 commits into from
Jun 28, 2019
Merged

fix(popup): remove body styles in onExitDOM #593

merged 6 commits into from
Jun 28, 2019

Conversation

fifoosid
Copy link
Contributor

No description provided.

@fifoosid
Copy link
Contributor Author

Fixes #592

@fifoosid
Copy link
Contributor Author

FIxes #589

pskelin
pskelin reviewed Jun 26, 2019
View reviewed changes
packages/main/src/Popup.js Outdated Show resolved Hide resolved
@fifoosid fifoosid changed the title fix(popup): remove body styles in disconnectedCallback fix(popup): remove body styles in onExitDOM Jun 27, 2019
@fifoosid fifoosid merged commit 410b8f6 into master Jun 28, 2019
@fifoosid fifoosid deleted the popup-body-styles branch June 28, 2019 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pskelin pskelin pskelin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fifoosid @pskelin