[Feature Request]: support auto-switch for versioned custom icon SVGs based on the current theme #7312
Closed
1 task done
Assignees
Labels
Comments
ilhan007
added a commit
that referenced
this issue
Aug 1, 2023
The PR aims to add support for registering versioned/theme dependent custom icon collections. Previously, one could register an icon collection (f.e. "my-icons") with the use of `registerIconLoader` and use it with the Icon web component. However, there is no API to register theme dependant version of the same icon, so that whenever the theme is changed the used SVGs are auto-switched behind the scenes. Now. `registerIconLoader` can be used to register additional second version (won't fail in case of multiple versions, but at the end the separation is "legacy" vs "sap_horizon" theme families) and use the newly supported field "themeFamily" to define in which themeFamily the icon collection should be used. If "themeFamily" is not present, by default it means in all themes (sap_belize_*, sap_fiori_3_*) other than "sap_horizon" theme families. Fixes: #7312
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature Request Description
For our standard icon collections (-icons, -icons-tnt, -icons-business-suite), we support two versions of each icon and based on the theme family set, we display the one or the other. This is not yet possible for custom icon SVGs that are registered, but recently requested.
Proposed Solution
Enhancing
registerIconLoaderto provide the necessary versioned info andgetIconCollectionByTheme,getIconCollectionByThemeinconfig/Icons.tsto the auto switch.Proposed Alternatives
No response
Organization
SAC
Additional Context
No response
Priority
None
Privacy Policy
The text was updated successfully, but these errors were encountered: