Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][SF][1.29.0][List][A11y][Expected Fixed Time: ASAP] The status violates the contrast demand when hovering on the list in high contrast mode #9869

Closed
1 task done
wilson-xu-sap opened this issue Sep 13, 2024 · 7 comments
Assignees

Comments

@wilson-xu-sap
Copy link

Describe the bug

The status violates the contrast demand when hovering on the list in HCB mode.

code example

import React, { useCallback, useMemo } from 'react';

import { List, StandardListItem } from '@ui5/webcomponents-react';
function App() {
  const data = [
    {
      id: 1,
      link: 'www.google.com',
      name: 'Notebook Basic',
      price: '956EUR',
      dimension: '30 x 18 x 3cm',
    },
    {
      id: 2,
      link: 'www.google.com',
      name: 'Notebook Basic',
      price: '956EUR',
      dimension: '30 x 18 x 3cm',
    },
    {
      id: 3,
      link: 'www.google.com',
      name: 'Notebook Basic',
      price: '956EUR',
      dimension: '30 x 18 x 3cm',
    },
    {
      id: 4,
      link: 'www.google.com',
      name: 'Notebook Basic',
      price: '956EUR',
      dimension: '30 x 18 x 3cm',
    },
    {
      id: 5,
      link: 'www.google.com',
      name: 'Notebook Basic',
      price: '956EUR',
      dimension: '30 x 18 x 3cm',
    },
    {
      id: 6,
      link: 'www.google.com',
      name: 'Notebook Basic',
      price: '956EUR',
      dimension: '30 x 18 x 3cm',
    },
    {
      id: 7,
      link: 'www.google.com',
      name: 'Notebook Basic',
      price: '956EUR',
      dimension: '30 x 18 x 3cm',
    },
    {
      id: 8,
      link: 'www.google.com',
      name: 'Notebook Basic',
      price: '956EUR',
      dimension: '30 x 18 x 3cm',
    },
    {
      id: 9,
      link: 'www.google.com',
      name: 'Notebook Basic',
      price: '956EUR',
      dimension: '30 x 18 x 3cm',
    },
    {
      id: 10,
      link: 'www.google.com',
      name: 'Notebook Basic',
      price: '956EUR',
      dimension: '30 x 18 x 3cm',
    },
    {
      id: 11,
      link: 'www.google.com',
      name: 'Notebook Basic',
      price: '956EUR',
      dimension: '30 x 18 x 3cm',
    },
    {
      id: 1,
      link: 'www.google.com',
      name: 'Notebook Basic',
      price: '956EUR',
      dimension: '30 x 18 x 3cm',
    },
    {
      id: 2,
      link: 'www.google.com',
      name: 'Notebook Basic',
      price: '956EUR',
      dimension: '30 x 18 x 3cm',
    },
    {
      id: 3,
      link: 'www.google.com',
      name: 'Notebook Basic',
      price: '956EUR',
      dimension: '30 x 18 x 3cm',
    },
    {
      id: 4,
      link: 'www.google.com',
      name: 'Notebook Basic',
      price: '956EUR',
      dimension: '30 x 18 x 3cm',
    },
    {
      id: 5,
      link: 'www.google.com',
      name: 'Notebook Basic',
      price: '956EUR',
      dimension: '30 x 18 x 3cm',
    },
    {
      id: 6,
      link: 'www.google.com',
      name: 'Notebook Basic',
      price: '956EUR',
      dimension: '30 x 18 x 3cm',
    },
    {
      id: 7,
      link: 'www.google.com',
      name: 'Notebook Basic',
      price: '956EUR',
      dimension: '30 x 18 x 3cm',
    },
    {
      id: 8,
      link: 'www.google.com',
      name: 'Notebook Basic',
      price: '956EUR',
      dimension: '30 x 18 x 3cm',
    },
    {
      id: 9,
      link: 'www.google.com',
      name: 'Notebook Basic',
      price: '956EUR',
      dimension: '30 x 18 x 3cm',
    },
    {
      id: 10,
      link: 'www.google.com',
      name: 'Notebook Basic',
      price: '956EUR',
      dimension: '30 x 18 x 3cm',
    },
    {
      id: 11,
      link: 'www.google.com',
      name: 'Notebook Basic',
      price: '956EUR',
      dimension: '30 x 18 x 3cm',
    },
    {
      id: 1,
      link: 'www.google.com',
      name: 'Notebook Basic',
      price: '956EUR',
      dimension: '30 x 18 x 3cm',
    },
    {
      id: 2,
      link: 'www.google.com',
      name: 'Notebook Basic',
      price: '956EUR',
      dimension: '30 x 18 x 3cm',
    },
    {
      id: 3,
      link: 'www.google.com',
      name: 'Notebook Basic',
      price: '956EUR',
      dimension: '30 x 18 x 3cm',
    },
  ];
  return (
    <>
      <List growing="None" headerText="List with ListItemStandard">
        {data.map((x) => {
          return (
            <StandardListItem
              additionalText="www"
              additionalTextState="Warning"
            ></StandardListItem>
          );
        })}
      </List>
    </>
  );
}

export default App;

Isolated Example

https://stackblitz.com/edit/github-xbtmwe-zgqwey?file=src%2FApp.tsx,src%2Fmain.tsx,node_modules%2F%40ui5%2Fwebcomponents-react%2Fdist%2Fcomponents%2FThemeProvider%2Findex.d.ts

Reproduction steps

  1. use HCB mode
  2. hover on the list item
  3. use CCA to test.

Expected Behaviour

No violation

Screenshots or Videos

image

UI5 Web Components for React Version

1.29.0

UI5 Web Components Version

1.24.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Relevant log output

No response

Organization

SF

Declaration

  • I’m not disclosing any internal or sensitive information.
@wilson-xu-sap wilson-xu-sap added the bug This issue is a bug in the code label Sep 13, 2024
@wilson-xu-sap
Copy link
Author

BTW, if we use object status on custom list item, it shares the same issue.

1 similar comment
@wilson-xu-sap
Copy link
Author

BTW, if we use object status on custom list item, it shares the same issue.

@MarcusNotheis
Copy link
Collaborator

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

@IlianaB
Copy link
Member

IlianaB commented Sep 16, 2024

Hello @ui5-webcomponents-topic-p I am forwarding this issue to you, because the contrast ration between the color of the additionalText in warning state and the color of the background of the list item when hovering in HCB mode is violated. Maybe this should also be discussed with design team.

Regards,
Iliana

@kgogov kgogov self-assigned this Oct 31, 2024
kgogov added a commit that referenced this issue Nov 28, 2024
The contrast of the additional text in the list item is not sufficient.
This change addresses the issue by increasing the contrast of the
additional text by adding a text shadow and aligning the component with
the design guidelines.

Fixes: #9869
kgogov added a commit that referenced this issue Nov 28, 2024
The contrast of the additional text in the list item is not sufficient.
This change addresses the issue by increasing the contrast of the
additional text by adding a text shadow and aligning the component with
the design guidelines.

Related: #9869
kgogov added a commit that referenced this issue Nov 28, 2024
The contrast of the additional text in the list item is not sufficient.
This change addresses the issue by increasing the contrast of the
additional text by adding a text shadow and aligning the component with
the design guidelines.

Fixes: #9869
kgogov added a commit that referenced this issue Dec 5, 2024
The contrast of the additional text in the list item is not sufficient.
This change addresses the issue by increasing the contrast of the
additional text by adding a text shadow and aligning the component with
the design guidelines.

Fixes: #9869
@kgogov
Copy link
Member

kgogov commented Dec 5, 2024

Hi @wilson-xu-sap,

This issue has been resolved with #10272.

Thank you for bringing this to our attention!
If you encounter any further issues or have additional feedback, feel free to reach out.

Best regards,
Konstantin

@kgogov kgogov closed this as completed Dec 5, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Completed in Maintenance - Topic P Dec 5, 2024
@wilson-xu-sap
Copy link
Author

Hi @wilson-xu-sap,

This issue has been resolved with #10272.

Thank you for bringing this to our attention! If you encounter any further issues or have additional feedback, feel free to reach out.

Best regards, Konstantin

Glad to hear that, thanks!

@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This issue has been resolved in version v1.24.14 🎉

The release is available on v1.24.14

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed
Development

No branches or pull requests

5 participants