Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Button | React | 1.20.0 | icons | theming | localization | i18n | typescript]: Buttons_No Visible focus #9894

Closed
1 task done
durgaprasad1995 opened this issue Sep 18, 2024 · 7 comments · Fixed by #10068
Assignees
Labels
ACC bug This issue is a bug in the code Medium Prio released TOPIC B

Comments

@durgaprasad1995
Copy link

Bug Description

When we are using this theme Quartz-light(sap_fiori_3) the button visible focus is not clear when compare the other's

Visible focus indicator is not clearly visible for all emphasized buttons.

image

Expected behavior
Strong and clear visible focus should be provided for all the UI elements.

Plug and play here (https://sap.github.io/ui5-webcomponents-react/v2/?path=/docs/inputs-button--docs&globals=theme:sap_fiori_3)

Affected Component

Button

Expected Behaviour

Strong and clear visible focus should be provided for all the UI elements.

Isolated Example

https://sap.github.io/ui5-webcomponents-react/v2/?path=/docs/inputs-button--docs&globals=theme:sap_fiori_3

Steps to Reproduce

1.Go to https://sap.github.io/ui5-webcomponents-react/v2/?path=/docs/inputs-button--docs&globals=theme:sap_fiori_3
2. select the theme Quartz-light
3. select the button design Emphasized
4. then click on tab on the button(example) check the focus
...

Log Output, Stack Trace or Screenshots

No response

Priority

High

UI5 Web Components Version

1.20.0

Browser

Chrome

Operating System

windows

Additional Context

No response

Organization

SAP

Declaration

  • I’m not disclosing any internal or sensitive information.
@durgaprasad1995 durgaprasad1995 added the bug This issue is a bug in the code label Sep 18, 2024
@IlianaB
Copy link
Member

IlianaB commented Sep 18, 2024

Hello @durgaprasad1995 ,
could you please share some information, what do you mean by "compared to the others"? Focus of the Emphasized button with Quartz Light theme is implemented according to the specification - 0.0625rem dotted #fff color.

Regards,
Iliana

@IlianaB IlianaB added author action bug This issue is a bug in the code TOPIC B and removed bug This issue is a bug in the code author action labels Sep 18, 2024
@IlianaB
Copy link
Member

IlianaB commented Sep 18, 2024

Hello @SAP/ui5-webcomponents-topic-b , you need to zoom too see actually there is a solid black border, set with styles:
:host([design="Emphasized"][desktop]) .ui5-button-root:focus-within::before, :host([design="Emphasized"]
That makes the focus not so clearly visible.

Regards,
Iliana

@durgaprasad1995
Copy link
Author

Hello @durgaprasad1995 , could you please share some information, what do you mean by "compared to the others"? Focus of the Emphasized button with Quartz Light theme is implemented according to the specification - 0.0625rem dotted #fff color.

Regards, Iliana

When compare to Other Theme for this theme (Quartz Light) focus is not very clear

In our application looks like this
image

@IlianaB
Copy link
Member

IlianaB commented Sep 19, 2024

Hello @durgaprasad1995 ,
thank you for sharing this with us! It wasn't very clear to me without zoom, but then I saw it. I believe the solid black border, seen through the dotted white one, should not be there. And because of it, the focus outline looks a little bit blurred.

Regards,
Iliana

@durgaprasad1995
Copy link
Author

Hi @IlianaB any update on this

@DMihaylova
Copy link

Hi @durgaprasad1995,

Thank you for your patience!
We're checking it and syncs with designers are taking place.
We'll update you soon.

Regards,
Diana

@DMihaylova DMihaylova self-assigned this Sep 30, 2024
@unazko unazko self-assigned this Oct 1, 2024
@unazko unazko closed this as completed in 2d2703e Oct 29, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Completed in Maintenance - Topic B Oct 29, 2024
kgogov pushed a commit that referenced this issue Oct 30, 2024
Issue:

- There was a double focus outline for the Emphasized button with the Quartz theme.

Fixes: #9894
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This issue has been resolved in version v2.4.0-rc.4 🎉

The release is available on v2.4.0-rc.4

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ACC bug This issue is a bug in the code Medium Prio released TOPIC B
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

5 participants