Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui5-slider]: Arrow Up and Down do not change properly the value in RTL mode #9967

Closed
1 task done
nikoletavnv opened this issue Oct 2, 2024 · 2 comments · Fixed by #10037
Closed
1 task done

[ui5-slider]: Arrow Up and Down do not change properly the value in RTL mode #9967

nikoletavnv opened this issue Oct 2, 2024 · 2 comments · Fixed by #10037
Assignees
Labels

Comments

@nikoletavnv
Copy link
Member

Bug Description

When slider is in RTL mode the Arrow Up should move the slider to the left to the bigger values, and Arrow Down should move the slider to the right. It is the expected behavior and how the native input of type "range" is working.
At the moment Arrow Up moves the slider to the right in both RTL and LTR mode.

Affected Component

ui5-slider

Expected Behaviour

No response

Isolated Example

No response

Steps to Reproduce

  1. Open https://sap.github.io/ui5-webcomponents/nightly/packages/main/test/pages/Slider.html
  2. Go to RTL example
  3. Try to change the value by using Arrow Up and Arrow Down keys
    ...

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

2.0.1

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@nikoletavnv nikoletavnv added bug This issue is a bug in the code ACC Medium Prio labels Oct 2, 2024
@nikoletavnv nikoletavnv self-assigned this Oct 16, 2024
nikoletavnv added a commit that referenced this issue Oct 28, 2024
* fix(ui5-slider): up and down arrow behavior in RTL mode

Fixes #9967

Remove redundant static method
@github-project-automation github-project-automation bot moved this from In progress to Completed in Maintenance - Topic RL Oct 28, 2024
kgogov pushed a commit that referenced this issue Oct 30, 2024
* fix(ui5-slider): up and down arrow behavior in RTL mode

Fixes #9967

Remove redundant static method
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This issue has been resolved in version v2.4.0-rc.4 🎉

The release is available on v2.4.0-rc.4

Your semantic-release bot 📦🚀

nikoletavnv added a commit that referenced this issue Nov 15, 2024
* fix(ui5-slider): up and down arrow behavior in RTL mode

Fixes #9967
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This issue has been resolved in version v1.24.14 🎉

The release is available on v1.24.14

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

3 participants