fix(ui5-dialog): width on mobile is not bigger than the phone width #10199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: When the base font in the 'html' element is changed to something different than the default 16px (for example 32px) the width of the dialog can become larger than the width of the phone's display. This is caused by the 'min-width' (20rem) of the dialog. For the dialog on phone it is recommended by the design to set the dialog's property 'stretch' to true to use the full screen size. The solution: When we have stretched dialog on phone the 'min-width' should not be applied (the width is 100%). fixes: #10000
LidiyaGeorgieva
requested review from
alexandar-mitsev,
TeodorTaushanov and
BorisDafov
TeodorTaushanov
requested changes
Nov 18, 2024
…ui5-dialog-stretch-min-width
BorisDafov
suggested changes
Nov 18, 2024
TeodorTaushanov
approved these changes
Nov 19, 2024
|
🎉 This PR is included in version v2.5.0-rc.1 🎉 The release is available on v2.5.0-rc.1 Your semantic-release bot 📦🚀 |
LidiyaGeorgieva
added a commit
that referenced
this pull request
Nov 26, 2024
…10199) Issue: When the base font in the 'html' element is changed to something different than the default 16px (for example 32px) the width of the dialog can become larger than the width of the phone's display. This is caused by the 'min-width' (20rem) of the dialog. For the dialog on phone it is recommended by the design to set the dialog's property 'stretch' to true to use the full screen size. The solution: When we have stretched dialog on phone the 'min-width' should not be applied (the width is 100%). fixes: #10000 downport of #10199
LidiyaGeorgieva
added a commit
that referenced
this pull request
Dec 2, 2024
…10255) Issue: When the base font in the 'html' element is changed to something different than the default 16px (for example 32px) the width of the dialog can become larger than the width of the phone's display. This is caused by the 'min-width' (20rem) of the dialog. For the dialog on phone it is recommended by the design to set the dialog's property 'stretch' to true to use the full screen size. The solution: When we have stretched dialog on phone the 'min-width' should not be applied (the width is 100%). fixes: #10000 downport of #10199
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: When the base font in the 'html' element is changed to something different than the default 16px (for example 32px) the width of the dialog can become larger than the width of the phone's display. This is caused by the 'min-width' (20rem) of the dialog. For the dialog on phone it is recommended by the design to set the dialog's property 'stretch' to true to use the full screen size.
The solution: When we have stretched dialog on phone the 'min-width' should not be applied (the width is 100%).
fixes: #10000