Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui5-list): handle arrow up and down navigation for load more button #10251

Merged
merged 1 commit into from
Nov 28, 2024
Merged

feat(ui5-list): handle arrow up and down navigation for load more button #10251

merged 1 commit into from
Nov 28, 2024

Conversation

NakataCode
Copy link
Contributor

@NakataCode NakataCode commented Nov 25, 2024 •
edited
Loading

The "Load More" button can now be accessed using the arrow up and down keys:

  • Pressing the arrow down key while focused on the last list item now moves focus to the "Load More" button.
  • Pressing the arrow up key while focused on the "Load More" button navigates back to the last item in the list.

Tests added for:

  • End key navigation: Moves focus from first item to last item and then to growing button
  • Arrow down/up navigation: Moves focus between last list item and growing button
  • Home key on growing button: Moves focus to first list item

@NakataCode NakataCode force-pushed the list-arrow-navigation-load-more branch from c1e7d18 to 0ffb8d6 Compare November 26, 2024 13:02
@NakataCode NakataCode marked this pull request as ready for review November 26, 2024 13:09
@plamenivanov91 plamenivanov91 self-requested a review November 28, 2024 09:30
plamenivanov91
plamenivanov91 requested changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@plamenivanov91 plamenivanov91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please implement the tests on cypress

@NakataCode NakataCode force-pushed the list-arrow-navigation-load-more branch from 0ffb8d6 to c09b03a Compare November 28, 2024 09:33
@plamenivanov91 plamenivanov91 self-requested a review November 28, 2024 09:35
@NakataCode NakataCode force-pushed the list-arrow-navigation-load-more branch from c09b03a to 32cca51 Compare November 28, 2024 10:07
@NakataCode NakataCode merged commit 3150793 into main Nov 28, 2024
10 checks passed
@NakataCode NakataCode deleted the list-arrow-navigation-load-more branch November 28, 2024 11:42
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This PR is included in version v2.5.0-rc.3 🎉

The release is available on v2.5.0-rc.3

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamenivanov91 plamenivanov91 plamenivanov91 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NakataCode @ui5-webcomponents-bot @plamenivanov91