Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-view-settings-dialog): adjust dialog heading level #10289

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

unazko
Copy link
Contributor

@unazko unazko commented Dec 3, 2024

The dialog is considered as a separate context so it's heading should be H1.

Related to: #10191

@unazko unazko marked this pull request as ready for review December 3, 2024 15:30
@unazko unazko merged commit 08d48a3 into SAP:main Dec 4, 2024
10 checks passed
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This PR is included in version v2.5.0-rc.3 🎉

The release is available on v2.5.0-rc.3

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants