feat(ui5-colorpicker): adjust visual design #10495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NHristov-sap
approved these changes
Jan 9, 2025
tsanislavgatev
approved these changes
Jan 21, 2025
|
After a review with the visual designer, there is still some work to be done which is why I am not merging yet :) |
NHristov-sap
approved these changes
Jan 27, 2025
vladitasev
approved these changes
Jan 27, 2025
|
🎉 This PR is included in version v2.7.0-rc.2 🎉 The release is available on v2.7.0-rc.2 Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The size and spacing of each slider in the
ui5-color-pickerhas been adjusted to fit to the visual specifications for Horizon Cozy and Compact themes.Note: The alignment of the buttons and inputs is also not according to specifications but has been addressed in the following change #10157.
The
ui5-color-pickernow looks as follows in Cozy and Compact themes respectively:Fixes: #10204